Removed welcome email editor feature flag (#26916)

EvanHahn · web-flow · commit b3bd8d19431f · 2026-03-25T20:57:25.000Z
closes https://linear.app/ghost/issue/NY-1105 This change should have no user impact. All it does is remove the flag, enabling the feature for everyone. In addition to automated tests, I manually verified that the new welcome email editor shows up.
diff --git a/apps/admin-x-settings/src/components/settings/membership/member-emails/welcome-email-modal.tsx b/apps/admin-x-settings/src/components/settings/membership/member-emails/welcome-email-modal.tsx
@@ -3,7 +3,6 @@ import React from 'react';
 import {useCallback, useEffect, useRef, useState} from 'react';
 
 import MemberEmailEditor from './member-email-editor';
-import useFeatureFlag from '../../../../hooks/use-feature-flag';
 import {Hint, Button as LegacyButton, Modal, TextField} from '@tryghost/admin-x-design-system';
 import {confirmIfDirty} from '@tryghost/admin-x-design-system';
 import {useForm, useHandleError} from '@tryghost/admin-x-framework/hooks';
@@ -125,7 +124,6 @@ const WelcomeEmailModal = NiceModal.create<WelcomeEmailModalProps>(({emailType =
     const {settings} = useGlobalData();
     const [siteTitle] = getSettingValues<string>(settings, ['title']);
     const {resolvedSenderName, resolvedSenderEmail, resolvedReplyToEmail, hasDistinctReplyTo} = useWelcomeEmailSenderDetails(automatedEmail);
-    const welcomeEmailEditorEnabled = useFeatureFlag('welcomeEmailEditor');
     const emailTypeLabel = emailType === 'paid' ? 'Paid' : 'Free';
     const modalTitle = `${emailTypeLabel} members welcome email`;
 
@@ -220,99 +218,6 @@ const WelcomeEmailModal = NiceModal.create<WelcomeEmailModalProps>(({emailType =
         }
     }, [setFormState, updateForm]);
 
-    if (!welcomeEmailEditorEnabled) {
-        return (
-            <Modal
-                afterClose={() => {
-                    updateRoute('memberemails');
-                }}
-                dirty={isDirty}
-                footer={false}
-                header={false}
-                testId='welcome-email-modal'
-                width={672}
-            >
-                <div className='-mx-8 flex h-[calc(100vh-16vmin)] flex-col overflow-y-auto dark:bg-grey-975!'>
-                    <div className='sticky top-0 z-10 flex flex-col gap-2 border-b border-grey-100 bg-white p-5 dark:border-grey-900 dark:bg-grey-975'>
-                        <div className='mb-2 flex items-center justify-between'>
-                            <h3 className='text-lg font-semibold'>{modalTitle}</h3>
-                            <div className='flex items-center gap-2'>
-                                <div ref={dropdownRef} className='relative'>
-                                    <LegacyButton
-                                        className='border border-grey-200 font-semibold hover:border-grey-300 hover:bg-white! dark:border-grey-900 dark:hover:border-grey-800 dark:hover:bg-grey-950!'
-                                        color="clear"
-                                        icon='send'
-                                        label="Test"
-                                        onClick={() => setShowTestDropdown(!showTestDropdown)}
-                                    />
-                                    {showTestDropdown && (
-                                        <TestEmailDropdown automatedEmailId={automatedEmail.id} lexical={formState.lexical} subject={formState.subject} validateForm={validate} onClose={() => setShowTestDropdown(false)} />
-                                    )}
-                                </div>
-                                <LegacyButton
-                                    color={okProps.color}
-                                    disabled={okProps.disabled}
-                                    label={saveButtonLabel}
-                                    onClick={async () => await handleSave({fakeWhenUnchanged: true})}
-                                />
-                            </div>
-                        </div>
-                        <div className='flex items-center'>
-                            <div className='w-20 shrink-0 font-semibold'>From:</div>
-                            <div className='min-w-0 grow'>
-                                <span className='flex gap-1 truncate whitespace-nowrap'>
-                                    <span>{resolvedSenderName}</span>
-                                    <span className='text-grey-700 dark:text-grey-400'>{`<${resolvedSenderEmail}>`}</span>
-                                </span>
-                            </div>
-                        </div>
-                        {hasDistinctReplyTo && (
-                            <div className='flex items-center py-0.5'>
-                                <div className='w-20 shrink-0 font-semibold'>Reply-to:</div>
-                                <div className='grow text-grey-700 dark:text-grey-400'>
-                                    {resolvedReplyToEmail}
-                                </div>
-                            </div>
-                        )}
-                        <div className='flex items-center'>
-                            <div className='w-20 shrink-0 font-semibold'>Subject:</div>
-                            <div className='grow'>
-                                <TextField
-                                    className='w-full'
-                                    error={Boolean(errors.subject)}
-                                    hint={errors.subject || ''}
-                                    maxLength={300}
-                                    placeholder={`Welcome to ${siteTitle}`}
-                                    value={formState.subject}
-                                    onChange={e => updateForm(state => ({...state, subject: e.target.value}))}
-                                />
-                            </div>
-                        </div>
-                    </div>
-                    <div className='flex grow flex-col bg-grey-50 p-8 dark:bg-grey-975'>
-                        <div
-                            className={`mx-auto flex w-full max-w-[600px] grow flex-col rounded border bg-white p-8 shadow-sm dark:bg-grey-950/25 dark:shadow-none ${errors.lexical ? 'border-red' : 'border-grey-200 dark:border-grey-925'}`}
-                            data-testid='welcome-email-editor'
-                            onFocus={() => {
-                                hasEditorBeenFocused.current = true;
-                            }}
-                        >
-                            <MemberEmailEditor
-                                key={automatedEmail?.id || 'new'}
-                                className='welcome-email-editor'
-                                placeholder='Write your welcome email content...'
-
-                                value={automatedEmail?.lexical || ''}
-                                onChange={handleEditorChange}
-                            />
-                        </div>
-                        {errors.lexical && <Hint className='mt-2 mr-auto ml-8 max-w-[600px]' color='red'>{errors.lexical}</Hint>}
-                    </div>
-                </div>
-            </Modal>
-        );
-    }
-
     return (
         <Modal
             afterClose={() => {
diff --git a/apps/admin-x-settings/test/acceptance/membership/member-welcome-emails.test.ts b/apps/admin-x-settings/test/acceptance/membership/member-welcome-emails.test.ts
@@ -34,21 +34,10 @@ const newslettersRequest = {
     browseNewslettersLimit: {method: 'GET', path: '/newsletters/?filter=status%3Aactive&limit=1', response: responseFixtures.newsletters}
 };
 
-const configWithWelcomeEmailEditorEnabled = {
+const configWithTenorEnabled = {
     ...responseFixtures.config,
     config: {
         ...responseFixtures.config.config,
-        labs: {
-            ...responseFixtures.config.config.labs,
-            welcomeEmailEditor: true
-        }
-    }
-};
-
-const configWithWelcomeEmailEditorAndTenorEnabled = {
-    ...configWithWelcomeEmailEditorEnabled,
-    config: {
-        ...configWithWelcomeEmailEditorEnabled.config,
         tenor: {
             googleApiKey: 'test-tenor-key',
             contentFilter: 'off'
@@ -249,7 +238,7 @@ test.describe('Member emails settings', async () => {
             const {lastApiRequests} = await mockApi({page, requests: {
                 ...globalDataRequests,
                 ...newslettersRequest,
-                browseConfig: {method: 'GET', path: '/config/', response: configWithWelcomeEmailEditorEnabled},
+                browseConfig: {method: 'GET', path: '/config/', response: responseFixtures.config},
                 browseAutomatedEmails: {method: 'GET', path: '/automated_emails/', response: automatedEmailsFixture},
                 fetchOembed: {
                     method: 'GET',
@@ -288,7 +277,7 @@ test.describe('Member emails settings', async () => {
             const {lastApiRequests} = await mockApi({page, requests: {
                 ...globalDataRequests,
                 ...newslettersRequest,
-                browseConfig: {method: 'GET', path: '/config/', response: configWithWelcomeEmailEditorEnabled},
+                browseConfig: {method: 'GET', path: '/config/', response: responseFixtures.config},
                 browseAutomatedEmails: {method: 'GET', path: '/automated_emails/', response: automatedEmailsFixture},
                 fetchOembed: {
                     method: 'GET',
@@ -337,7 +326,7 @@ test.describe('Member emails settings', async () => {
             await mockApi({page, requests: {
                 ...globalDataRequests,
                 ...newslettersRequest,
-                browseConfig: {method: 'GET', path: '/config/', response: configWithWelcomeEmailEditorEnabled},
+                browseConfig: {method: 'GET', path: '/config/', response: responseFixtures.config},
                 browseAutomatedEmails: {method: 'GET', path: '/automated_emails/', response: automatedEmailsFixture}
             }});
 
@@ -365,7 +354,7 @@ test.describe('Member emails settings', async () => {
             await mockApi({page, requests: {
                 ...globalDataRequests,
                 ...newslettersRequest,
-                browseConfig: {method: 'GET', path: '/config/', response: configWithWelcomeEmailEditorEnabled},
+                browseConfig: {method: 'GET', path: '/config/', response: responseFixtures.config},
                 browseAutomatedEmails: {method: 'GET', path: '/automated_emails/', response: automatedEmailsFixture}
             }});
 
@@ -406,7 +395,7 @@ test.describe('Member emails settings', async () => {
             await mockApi({page, requests: {
                 ...globalDataRequests,
                 ...newslettersRequest,
-                browseConfig: {method: 'GET', path: '/config/', response: configWithWelcomeEmailEditorEnabled},
+                browseConfig: {method: 'GET', path: '/config/', response: responseFixtures.config},
                 browseAutomatedEmails: {method: 'GET', path: '/automated_emails/', response: automatedEmailsFixture}
             }});
 
@@ -449,7 +438,7 @@ test.describe('Member emails settings', async () => {
             await mockApi({page, requests: {
                 ...globalDataRequests,
                 ...newslettersRequest,
-                browseConfig: {method: 'GET', path: '/config/', response: configWithWelcomeEmailEditorAndTenorEnabled},
+                browseConfig: {method: 'GET', path: '/config/', response: configWithTenorEnabled},
                 browseAutomatedEmails: {method: 'GET', path: '/automated_emails/', response: automatedEmailsFixture}
             }});
 
diff --git a/ghost/core/core/shared/labs.js b/ghost/core/core/shared/labs.js
@@ -25,7 +25,6 @@ const GA_FEATURES = [
     'explore',
     'commentModeration',
     'featurebaseFeedback',
-    'welcomeEmailEditor',
     'transistor'
 ];
 
diff --git a/ghost/core/test/e2e-api/admin/__snapshots__/config.test.js.snap b/ghost/core/test/e2e-api/admin/__snapshots__/config.test.js.snap
@@ -31,7 +31,6 @@ Object {
       "transistor": true,
       "urlCache": true,
       "verificationFlow": true,
-      "welcomeEmailEditor": true,
       "welcomeEmailsDesignCustomization": true,
     },
     "mail": "",
diff --git a/ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap b/ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap
@@ -1675,7 +1675,7 @@ exports[`Settings API Edit can edit Stripe settings when Stripe Connect limit is
 Object {
   "access-control-allow-origin": "http://127.0.0.1:2369",
   "cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0",
-  "content-length": "5171",
+  "content-length": "5143",
   "content-type": "application/json; charset=utf-8",
   "content-version": StringMatching /v\\\\d\\+\\\\\\.\\\\d\\+/,
   "etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/,
