Explicitly assert that analytics requests trigger

refs https://linear.app/ghost/issue/BER-3077/improve-e2e-testing-integration

Always waiting for the analytics request to succeed means any public test will
fail if Tinybird or the analytics service isn't running.

Author: jonatansberg

e2e/helpers/pages/public/public-page.ts

@@ -1,5 +1,5 @@
 import {BasePage, pageGotoOptions} from '@/helpers/pages';
-import {Locator, Page, Response} from '@playwright/test';
+import {Locator, Page} from '@playwright/test';
 
 declare global {
     interface Window {
@@ -86,13 +86,11 @@ export class PublicPage extends BasePage {
 
     async goto(url?: string, options?: pageGotoOptions): Promise<void> {
         await this.enableAnalyticsRequests();
-        const pageHitPromise = this.pageHitRequestPromise();
         await super.goto(url, options);
-        await pageHitPromise;
     }
-
-    pageHitRequestPromise(): Promise<Response> {
-        return this.page.waitForResponse((response) => {
+    
+    async waitForPageHitRequest() {
+        return await this.page.waitForResponse((response) => {
             return response
                 .url()
                 .includes('/.ghost/analytics/api/v1/page_hit') && response.request().method() === 'POST';

e2e/tests/public/homepage.test.ts

@@ -9,4 +9,15 @@ test.describe('Ghost Public - Homepage', () => {
         await expect(homePage.title).toBeVisible();
         await expect(homePage.mainSubscribeButton).toBeVisible();
     });
+
+    test('sends page hit request', async ({page}) => {
+        const homePage = new HomePage(page);
+
+        // Set up request expectation before navigation
+        const response = homePage.waitForPageHitRequest();
+        await homePage.goto();
+
+        // Wait for the request to be fulfilled
+        await expect(response).resolves.toBeDefined();
+    });
 });