Skip to content

Commit cee778d

Browse files
authored
Merge pull request #705 from indutny/fix/race-in-async-h
async: remove racey `uv_ref()`/`uv_unref()`
2 parents 7322ea7 + 553c6ea commit cee778d

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

src/async.h

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,6 @@ template <class Item, class Parent> class Async {
3636
rows.swap(async->data);
3737
NODE_SQLITE3_MUTEX_UNLOCK(&async->mutex)
3838
for (unsigned int i = 0, size = rows.size(); i < size; i++) {
39-
#if NODE_VERSION_AT_LEAST(0, 7, 9)
40-
uv_unref((uv_handle_t *)&async->watcher);
41-
#else
42-
uv_unref(uv_default_loop());
43-
#endif
4439
async->callback(async->parent, rows[i]);
4540
}
4641
}
@@ -61,12 +56,6 @@ template <class Item, class Parent> class Async {
6156
}
6257

6358
void add(Item* item) {
64-
// Make sure node runs long enough to deliver the messages.
65-
#if NODE_VERSION_AT_LEAST(0, 7, 9)
66-
uv_ref((uv_handle_t *)&watcher);
67-
#else
68-
uv_ref(uv_default_loop());
69-
#endif
7059
NODE_SQLITE3_MUTEX_LOCK(&mutex);
7160
data.push_back(item);
7261
NODE_SQLITE3_MUTEX_UNLOCK(&mutex)

0 commit comments

Comments
 (0)