Clarify naming convention

Author: islathehut

3rd-party/auth

@@ -58,53 +58,53 @@ describe('QSSAuthConnectionManager', () => {
     const conn = qssAuthConnManager.getConnection(sigchainService.activeChain.team!.id)
     expect(conn).toBeDefined()
     expect(conn?.joinStatus).toBe(JoinStatus.JOINED)
-    expect(conn?.active).toBeTruthy()
+    expect(conn?.running).toBeTruthy()
   })
 
   it(`doesn't start a new connection when an existing connection is in place`, async () => {
     await qssAuthConnManager.startNewConnection(sigchainService.activeChain.team!.id)
     const conn = qssAuthConnManager.getConnection(sigchainService.activeChain.team!.id)
     expect(conn).toBeDefined()
     expect(conn?.joinStatus).toBe(JoinStatus.JOINED)
-    expect(conn?.active).toBeTruthy()
+    expect(conn?.running).toBeTruthy()
 
     await qssAuthConnManager.startNewConnection(sigchainService.activeChain.team!.id)
     const possiblyNewConn = qssAuthConnManager.getConnection(sigchainService.activeChain.team!.id)
     expect(possiblyNewConn).toBeDefined()
     expect(possiblyNewConn!.id).toEqual(conn!.id)
-    expect(possiblyNewConn?.active).toBeTruthy()
+    expect(possiblyNewConn?.running).toBeTruthy()
   })
 
   it(`restarts existing connection when a connection is in place but isn't active`, async () => {
     await qssAuthConnManager.startNewConnection(sigchainService.activeChain.team!.id)
     const conn = qssAuthConnManager.getConnection(sigchainService.activeChain.team!.id)
     expect(conn).toBeDefined()
     expect(conn?.joinStatus).toBe(JoinStatus.JOINED)
-    expect(conn?.active).toBeTruthy()
+    expect(conn?.running).toBeTruthy()
     conn?.stop(false)
-    expect(conn?.active).toBeFalsy()
+    expect(conn?.running).toBeFalsy()
 
     await qssAuthConnManager.startNewConnection(sigchainService.activeChain.team!.id)
     const possiblyNewConn = qssAuthConnManager.getConnection(sigchainService.activeChain.team!.id)
     expect(possiblyNewConn).toBeDefined()
     expect(possiblyNewConn!.id).toEqual(conn!.id)
-    expect(possiblyNewConn?.active).toBeTruthy()
+    expect(possiblyNewConn?.running).toBeTruthy()
   })
 
   it(`starts a new connection when a connection is closed and removed`, async () => {
     await qssAuthConnManager.startNewConnection(sigchainService.activeChain.team!.id)
     const conn = qssAuthConnManager.getConnection(sigchainService.activeChain.team!.id)
     expect(conn).toBeDefined()
     expect(conn?.joinStatus).toBe(JoinStatus.JOINED)
-    expect(conn?.active).toBeTruthy()
+    expect(conn?.running).toBeTruthy()
     qssAuthConnManager.stopConnection(sigchainService.activeChain.team!.id)
-    expect(conn?.active).toBeFalsy()
+    expect(conn?.running).toBeFalsy()
 
     await qssAuthConnManager.startNewConnection(sigchainService.activeChain.team!.id)
     const possiblyNewConn = qssAuthConnManager.getConnection(sigchainService.activeChain.team!.id)
     expect(possiblyNewConn).toBeDefined()
     expect(possiblyNewConn?.joinStatus).toBe(JoinStatus.JOINED)
-    expect(possiblyNewConn?.active).toBeTruthy()
+    expect(possiblyNewConn?.running).toBeTruthy()
     expect(possiblyNewConn!.id).not.toEqual(conn!.id)
   })
 })

3rd-party/qss

@@ -45,7 +45,7 @@ export class QSSAuthConnectionManager extends EventEmitter implements OnModuleDe
         }
 
         const authConnection = this.getConnection(message.payload.teamId)
-        if (authConnection == null || !authConnection.active) {
+        if (authConnection == null || !authConnection.running) {
           throw new Error(
             `Auth connection for team ${message.payload.teamId} wasn't initialized, can't process auth sync message`
           )
@@ -79,7 +79,7 @@ export class QSSAuthConnectionManager extends EventEmitter implements OnModuleDe
     const existingAuthConnection = this.authConnMap.get(teamId)
     // if we have an existing auth connection with QSS for this team and it is active, do nothing
     if (existingAuthConnection != null) {
-      if (existingAuthConnection.active) {
+      if (existingAuthConnection.running) {
         this.logger.warn('Existing active auth connection with QSS found for this team ID', teamId)
         return
       }

packages/backend/src/nest/qss/qss-auth-conn-manager.service.spec.ts

@@ -103,7 +103,7 @@ export class QSSAuthConnection extends EventEmitter {
    * This is true when the connection is starting up or has successfully completed the identity handshake
    * and is actively syncing sigchain updates with QSS
    */
-  public get active(): boolean {
+  public get running(): boolean {
     return [QSSAuthConnStatus.STARTING, QSSAuthConnStatus.ACTIVE].includes(this.connStatus)
   }
 
@@ -141,7 +141,7 @@ export class QSSAuthConnection extends EventEmitter {
     if (this._authConnection != null) {
       // if we have an existing auth connection for this team check if it has been started and is active, if so
       // do nothing
-      if (this._authConnection._started && this.active) {
+      if (this._authConnection._started && this.running) {
         this.logger.error(`Auth connection already started with QSS for this team`, this.teamId)
         return
       }
@@ -268,7 +268,7 @@ export class QSSAuthConnection extends EventEmitter {
   }
 
   public deliver(message: Uint8Array): void {
-    if (this._authConnection == null || !this.active) {
+    if (this._authConnection == null || !this.running) {
       throw new Error(`Auth connection with QSS for team ${this.teamId} needs to be initialized!`)
     }