Skip to content

Commit 5d079e7

Browse files
committed
Update selenium and electron-chrome selenium plugin for end 2 end tests. Fixes the e2e stuff that fails on GitHub now that electron has changed versions. Added this step to new nodejs upgrade guide doc
1 parent 62f1492 commit 5d079e7

3 files changed

Lines changed: 66 additions & 63 deletions

File tree

docs/Upgrading Nodejs.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,11 @@ New versions of add/remove command line flags. If you need to make this change u
109109
```
110110
7. Update `electron`
111111

112-
Migrate `packages/desktop/package.json` to an electron version that ships with the new node verison.
112+
Migrate `packages/desktop/package.json` to an electron version that ships with the new node verison.
113+
114+
- You can see each major electron release's nodejs [here](https://releases.electronjs.org/release?channel=stable)
115+
- Pay careful attention to breaking changes within electron releases. APIs can be removed which will make your project fail to build. But also, and more subtly, the behavior of a certain API may change causing Quiet to build and perhaps seem OK, but something is now behaving differently and/or incorrectly.
116+
- Upgrade the `selenium-webdriver` and the `electron-chromedriver` modules in `packages/e2e-tests/package.json`. `electron-chromedriver` should match the major version of `electron` that you just migrated to in the `desktop` package.
113117

114118
8. Bootsrap
115119

packages/e2e-tests/package-lock.json

Lines changed: 59 additions & 60 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/e2e-tests/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,12 @@
3737
"@quiet/types": "^2.0.2-alpha.1",
3838
"backend-bundle": "^2.0.1-alpha.4",
3939
"cross-env": "^5.2.0",
40-
"electron-chromedriver": "23.3.13",
40+
"electron-chromedriver": "^29",
4141
"get-port": "^5.1.1",
4242
"jest": "^29.4.2",
4343
"luxon": "^3.4.4",
4444
"path-browserify": "^1.0.1",
45-
"selenium-webdriver": "^4.8.0",
45+
"selenium-webdriver": "^4.41.0",
4646
"yargs": "^17.3.1"
4747
},
4848
"jest": {

0 commit comments

Comments
 (0)