Merged
Conversation
Contributor
|
@chaosphere2112 can we have bit more interest test? |
Contributor
|
@aashish24 boringcan be good sometimes! @chaosphere2112 I do not like your yellow, but I will approve anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you update canvas.backgroundcolor after rendering and do canvas.update(), the canvas' background color does not update. Added tests for that, and fixed the bug. I'm up for moving the fix to a different place, but the backend.clear() function was the most convenient location (since there was already an if statement that separated out the specific renderer I was looking to update, and gets called during every update()). Incoming PR for uvcdat-testdata to provide the images as well.