Issue423 durack1 add vacumm package#1073
Issue423 durack1 add vacumm package#1073aashish24 merged 3 commits intoCDAT:masterfrom durack1:issue423_durack1_AddVacummPackage
Conversation
|
@doutriaux1 it seems like this is being prompted to build: |
|
@durack1 you need to make them dependent on python at least |
|
@doutriaux1 isn't that achieved in the vacumm_deps.cmake file |
There was a problem hiding this comment.
@durack1 should be
set(vacumm_deps ${python_pkg})
There was a problem hiding this comment.
Ok well if that's the case then h5py will likely also need a tweak: https://github.com/UV-CDAT/uvcdat/blob/master/CMake/cdat_modules/h5py_deps.cmake#L1
set(h5py ${hdf5_pkg} ${python_pkg})
|
LGTM 👍 |
Issue423 durack1 add vacumm package
|
@doutriaux1 this PR has been reverted, not sure why it's not showing up here - but #1089 includes all the components to close this |
|
vacumm also depends on pytz. |
|
Thanks for the tipoff @stefraynaud I went off the dependency list at http://www.ifremer.fr/vacumm/user.install.prereqalt.html which didn't list pytz - can you double check the dependencies that we currently have in, it's likely these will need to be further revised then.. @aashish24 maybe hold off merging #1089 until this dependency check has been done.. |
|
@durack1, pytz was previously included in matplotlib, and I just discovered that it's no longer the case. So it becomes an explicit dependency for vacumm for the moment, and its website must be updated. Just a remark: when vacumm is installed inside an UVCDAT architecture, a more appropriate list of dependencies is: http://www.ifremer.fr/vacumm/user.install.prereq.html#other-packages Since pytz adds timezone support to matplotlib and since it is a little package that is useful for geographic information management, perhaps you can include it into uvcdat. |
|
Another point: I'm not personally maintaining the vacumm website at IFREMER http://www.ifremer.fr/vacumm |
@doutriaux1 take a look at this in response to #423