Fixed some VTK error messages that showed up when ending configure#1177
Merged
aashish24 merged 2 commits intoCDAT:masterfrom Mar 27, 2015
Merged
Fixed some VTK error messages that showed up when ending configure#1177aashish24 merged 2 commits intoCDAT:masterfrom
aashish24 merged 2 commits intoCDAT:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
You shouldn't need this but if you do then you want to set self.renderer = None since at this point I think it won't be of further use.
Contributor
Author
There was a problem hiding this comment.
Yeah, I basically only added this line as backup in case I screwed something up elsewhere; the "detach" functions are used throughout my vtk_ui package to make elements completely remove themselves from the VTK render stack and make them garbage collectable. I'll go ahead and set renderer to None here.
aashish24
added a commit
that referenced
this pull request
Mar 27, 2015
Fixed some VTK error messages that showed up when ending configure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should hopefully fix @williams13's VTK error messages; managed to reproduce them locally and eliminated them. They cropped up when closing the configure menu when a bunch of plots were open.