Add namespace for CMake targets

kprussing · kprussing · commit 808803ceeb6d · 2019-11-19T14:45:21.000-05:00
The usual convention with modern CMake is to namespace the targets.
This gives the netCDF namespace to the package.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -2043,6 +2043,7 @@ set(ConfigPackageLocation ${CMAKE_INSTALL_LIBDIR}/cmake/netCDF)
 install(EXPORT netCDFTargets
   DESTINATION ${ConfigPackageLocation}
   COMPONENT headers
+  NAMESPACE netCDF::
   )
 
 include(CMakePackageConfigHelpers)
@@ -2063,6 +2064,7 @@ INSTALL(
   COMPONENT headers
   )
 
+add_library(netCDF::netcdf ALIAS netcdf)
 target_include_directories(netcdf
     PUBLIC
         $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>

Original file line number	Diff line number	Diff line change
`@@ -2043,6 +2043,7 @@ set(ConfigPackageLocation ${CMAKE_INSTALL_LIBDIR}/cmake/netCDF)`
`2043`	`2043`	`install(EXPORT netCDFTargets`
`2044`	`2044`	`DESTINATION ${ConfigPackageLocation}`
`2045`	`2045`	`COMPONENT headers`
	`2046`	`+ NAMESPACE netCDF::`
`2046`	`2047`	`)`
`2047`	`2048`
`2048`	`2049`	`include(CMakePackageConfigHelpers)`
`@@ -2063,6 +2064,7 @@ INSTALL(`
`2063`	`2064`	`COMPONENT headers`
`2064`	`2065`	`)`
`2065`	`2066`
	`2067`	`+add_library(netCDF::netcdf ALIAS netcdf)`
`2066`	`2068`	`target_include_directories(netcdf`
`2067`	`2069`	`PUBLIC`
`2068`	`2070`	`$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>`