Skip to content

Commit bec1ca4

Browse files
committed
Surface report build errors with traceback; fix threshold to 85; error report instead of empty string
1 parent 36cfc17 commit bec1ca4

1 file changed

Lines changed: 12 additions & 4 deletions

File tree

.github/ISSUE_SCRIPT/horizontal_grid_cell.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -174,13 +174,21 @@ def update(files_to_write, parsed_issue, issue, dry_run=False):
174174
# Use pydantic-compatible copy if available, else fall back to data
175175
pydantic_overrides = files_to_write.get('_pydantic_data', {})
176176
validation_item = pydantic_overrides.get(file_path, data)
177-
data['_validation_report'] = ReportBuilder(
177+
report = ReportBuilder(
178178
folder_url=f"emd:{kind}", kind=kind,
179-
item=validation_item, link_threshold=80.0,
179+
item=validation_item, link_threshold=85.0,
180180
).build()
181+
data['_validation_report'] = report
182+
print(f" Report generated ({len(report)} chars)", flush=True)
181183
except Exception as e:
182-
print(f" WARNING Report generation failed: {e}", flush=True)
183-
data['_validation_report'] = ''
184+
import traceback
185+
tb = traceback.format_exc()
186+
print(f" WARNING Report generation failed: {e}\n{tb}", flush=True)
187+
data['_validation_report'] = (
188+
f"## Review Report\n\n"
189+
f"> [!WARNING]\n"
190+
f"> Report generation failed: `{e}`\n"
191+
)
184192

185193
if atid:
186194
import json as _json

0 commit comments

Comments
 (0)