Cherrypick SCC with indirect effects

Author: stevenfontanella

src/passes/GlobalEffects.cpp

@@ -21,8 +21,10 @@
 
 #include "ir/effects.h"
 #include "ir/module-utils.h"
+#include "ir/subtypes.h"
 #include "pass.h"
 #include "support/strongly_connected_components.h"
+#include "support/utilities.h"
 #include "wasm.h"
 
 namespace wasm {
@@ -39,6 +41,9 @@ struct FuncInfo {
 
   // Directly-called functions from this function.
   std::unordered_set<Name> calledFunctions;
+
+  // Types that are targets of indirect calls.
+  std::unordered_set<HeapType> indirectCalledTypes;
 };
 
 std::map<Function*, FuncInfo> analyzeFuncs(Module& module,
@@ -83,11 +88,19 @@ std::map<Function*, FuncInfo> analyzeFuncs(Module& module,
             if (auto* call = curr->dynCast<Call>()) {
               // Note the direct call.
               funcInfo.calledFunctions.insert(call->target);
+            } else if (effects.calls && options.closedWorld) {
+              HeapType type;
+              if (auto* callRef = curr->dynCast<CallRef>()) {
+                type = callRef->target->type.getHeapType();
+              } else if (auto* callIndirect = curr->dynCast<CallIndirect>()) {
+                type = callIndirect->heapType;
+              } else {
+                assert(false && "Unexpected type of call");
+              }
+
+              funcInfo.indirectCalledTypes.insert(type);
             } else if (effects.calls) {
-              // This is an indirect call of some sort, so we must assume the
-              // worst. To do so, clear the effects, which indicates nothing
-              // is known (so anything is possible).
-              // TODO: We could group effects by function type etc.
+              assert(!options.closedWorld);
               funcInfo.effects = UnknownEffects;
             } else {
               // No call here, but update throwing if we see it. (Only do so,
@@ -107,14 +120,52 @@ std::map<Function*, FuncInfo> analyzeFuncs(Module& module,
   return std::move(analysis.map);
 }
 
-std::unordered_map<Function*, std::unordered_set<Function*>>
-buildCallGraph(const Module& module,
-               const std::map<Function*, FuncInfo>& funcInfos) {
-  std::unordered_map<Function*, std::unordered_set<Function*>> callGraph;
-  for (const auto& [func, info] : funcInfos) {
-    for (Name callee : info.calledFunctions) {
-      callGraph[func].insert(module.getFunction(callee));
+using CallGraphNode = std::variant<Function*, HeapType>;
+
+// Build a call graph for indirect and direct calls.
+// key (callee) -> value (caller)
+// Name         -> Name     : callee is called directly by caller
+// Name         -> HeapType : callee is a potential target of a virtual call
+//                            with this HeapType
+// HeapType     -> Name     : callee is indirectly called by caller
+// HeapType     -> HeapType : callee is a subtype of caller If we're
+// running in an open world, we only include Name -> Name edges.
+std::unordered_map<CallGraphNode, std::unordered_set<CallGraphNode>>
+buildCallGraph(Module& module,
+               const std::map<Function*, FuncInfo>& funcInfos,
+               bool closedWorld) {
+  std::unordered_map<CallGraphNode, std::unordered_set<CallGraphNode>>
+    callGraph;
+
+  if (!closedWorld) {
+    for (const auto& [caller, callerInfo] : funcInfos) {
+      for (Name calleeFunction : callerInfo.calledFunctions) {
+        callGraph[caller].insert(module.getFunction(calleeFunction));
+      }
+    }
+    return callGraph;
+  }
+
+  std::unordered_set<HeapType> allFunctionTypes;
+  for (const auto& [caller, callerInfo] : funcInfos) {
+    for (Name calleeFunction : callerInfo.calledFunctions) {
+      callGraph[caller].insert(module.getFunction(calleeFunction));
+    }
+
+    allFunctionTypes.insert(caller->type.getHeapType());
+    for (HeapType calleeType : callerInfo.indirectCalledTypes) {
+      callGraph[caller].insert(calleeType);
+      allFunctionTypes.insert(calleeType);
     }
+    callGraph[caller->type.getHeapType()].insert(caller);
+  }
+
+  SubTypes subtypes(module);
+  for (HeapType type : allFunctionTypes) {
+    subtypes.iterSubTypes(type, [&callGraph, type](HeapType sub, auto _) {
+      callGraph[type].insert(sub);
+      return true;
+    });
   }
 
   return callGraph;
@@ -130,69 +181,79 @@ buildCallGraph(const Module& module,
 // - Also merge the (already computed) effects of each callee CC
 // - Add trap effects for potentially recursive call chains
 void propagateEffects(
-  const Module& module,
+  Module& module,
   const PassOptions& passOptions,
   std::map<Function*, FuncInfo>& funcInfos,
-  const std::unordered_map<Function*, std::unordered_set<Function*>>
+  const std::unordered_map<CallGraphNode, std::unordered_set<CallGraphNode>>&
     callGraph) {
+
   struct CallGraphSCCs
-    : SCCs<std::vector<Function*>::const_iterator, CallGraphSCCs> {
+    : SCCs<std::vector<CallGraphNode>::const_iterator, CallGraphSCCs> {
     const std::map<Function*, FuncInfo>& funcInfos;
-    const std::unordered_map<Function*, std::unordered_set<Function*>>&
-      callGraph;
     const Module& module;
+    const std::unordered_map<CallGraphNode, std::unordered_set<CallGraphNode>>&
+      callGraph;
 
     CallGraphSCCs(
-      const std::vector<Function*>& funcs,
+      const std::vector<CallGraphNode>& nodes,
       const std::map<Function*, FuncInfo>& funcInfos,
-      const std::unordered_map<Function*, std::unordered_set<Function*>>&
-        callGraph,
-      const Module& module)
-      : SCCs<std::vector<Function*>::const_iterator, CallGraphSCCs>(
-          funcs.begin(), funcs.end()),
-        funcInfos(funcInfos), callGraph(callGraph), module(module) {}
-
-    void pushChildren(Function* f) {
-      auto callees = callGraph.find(f);
+      Module& module,
+      const std::unordered_map<CallGraphNode,
+                               std::unordered_set<CallGraphNode>>& callGraph)
+      : SCCs<std::vector<CallGraphNode>::const_iterator, CallGraphSCCs>(
+          nodes.begin(), nodes.end()),
+        funcInfos(funcInfos), module(module), callGraph(callGraph) {}
+
+    void pushChildren(CallGraphNode node) {
+      auto callees = callGraph.find(node);
       if (callees == callGraph.end()) {
         return;
       }
-
-      for (auto* callee : callees->second) {
+      for (CallGraphNode callee : callees->second) {
         push(callee);
       }
     }
   };
 
-  std::vector<Function*> allFuncs;
+  // We only care about Functions that are roots, not types
+  // A type would be a root if a function exists with that type, but no-one
+  // indirect calls the type.
+  std::vector<CallGraphNode> allFuncs;
   for (auto& [func, info] : funcInfos) {
     allFuncs.push_back(func);
   }
-  CallGraphSCCs sccs(allFuncs, funcInfos, callGraph, module);
 
-  std::unordered_map<Function*, int> sccMembers;
+  CallGraphSCCs sccs(allFuncs, funcInfos, module, callGraph);
+
+  std::unordered_map<CallGraphNode, int> sccMembers;
   std::unordered_map<int, std::optional<EffectAnalyzer>> componentEffects;
 
   int ccIndex = 0;
   for (auto ccIterator : sccs) {
     ccIndex++;
     std::optional<EffectAnalyzer>& ccEffects = componentEffects[ccIndex];
-    std::vector<Function*> ccFuncs(ccIterator.begin(), ccIterator.end());
+    std::vector<CallGraphNode> cc(ccIterator.begin(), ccIterator.end());
 
     ccEffects.emplace(passOptions, module);
 
-    for (Function* f : ccFuncs) {
-      sccMembers.emplace(f, ccIndex);
+    std::vector<Function*> ccFuncs;
+    for (CallGraphNode node : cc) {
+      sccMembers.emplace(node, ccIndex);
+      if (auto** func = std::get_if<Function*>(&node)) {
+        ccFuncs.push_back(*func);
+      }
     }
 
     std::unordered_set<int> calleeSccs;
-    for (Function* caller : ccFuncs) {
+    for (CallGraphNode caller : cc) {
       auto callees = callGraph.find(caller);
-      if (callees == callGraph.end()) {
-        continue;
-      }
-      for (auto* callee : callees->second) {
-        calleeSccs.insert(sccMembers.at(callee));
+      if (callees != callGraph.end()) {
+        for (const auto& callee : callees->second) {
+          auto sccIt = sccMembers.find(callee);
+          if (sccIt != sccMembers.end()) {
+            calleeSccs.insert(sccIt->second);
+          }
+        }
       }
     }
 
@@ -210,11 +271,12 @@ void propagateEffects(
     }
 
     // Add trap effects for potential cycles.
-    if (ccFuncs.size() > 1) {
+    if (cc.size() > 1) {
       if (ccEffects != UnknownEffects) {
         ccEffects->trap = true;
       }
-    } else {
+      // A cycle isn't possible for a CC that only contains a type
+    } else if (ccFuncs.size() == 1) {
       auto* func = ccFuncs[0];
       if (funcInfos.at(func).calledFunctions.contains(func->name)) {
         if (ccEffects != UnknownEffects) {
@@ -263,7 +325,8 @@ struct GenerateGlobalEffects : public Pass {
     std::map<Function*, FuncInfo> funcInfos =
       analyzeFuncs(*module, getPassOptions());
 
-    auto callGraph = buildCallGraph(*module, funcInfos);
+    auto callGraph =
+      buildCallGraph(*module, funcInfos, getPassOptions().closedWorld);
 
     propagateEffects(*module, getPassOptions(), funcInfos, callGraph);
 

src/support/utilities.h

@@ -94,6 +94,10 @@ class Fatal {
 #define WASM_UNREACHABLE(msg) wasm::handle_unreachable()
 #endif
 
+template<class... Ts> struct overloaded : Ts... {
+  using Ts::operator()...;
+};
+template<class... Ts> overloaded(Ts...) -> overloaded<Ts...>;
 } // namespace wasm
 
 #endif // wasm_support_utilities_h