Avoid repeated lookup

stevenfontanella · stevenfontanella · commit 0a2f0ddd6abb · 2026-04-16T22:11:29.000Z
diff --git a/src/passes/GlobalEffects.cpp b/src/passes/GlobalEffects.cpp
@@ -113,8 +113,13 @@ CallGraph buildCallGraph(const Module& module,
                          const std::map<Function*, FuncInfo>& funcInfos) {
   CallGraph callGraph;
   for (const auto& [func, info] : funcInfos) {
+    if (info.calledFunctions.empty()) {
+      continue;
+    }
+
+    auto& callees = callGraph[func];
     for (Name callee : info.calledFunctions) {
-      callGraph[func].insert(module.getFunction(callee));
+      callees.insert(module.getFunction(callee));
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -113,8 +113,13 @@ CallGraph buildCallGraph(const Module& module,`
`113`	`113`	`const std::map<Function*, FuncInfo>& funcInfos) {`
`114`	`114`	`CallGraph callGraph;`
`115`	`115`	`for (const auto& [func, info] : funcInfos) {`
	`116`	`+ if (info.calledFunctions.empty()) {`
	`117`	`+ continue;`
	`118`	`+ }`
	`119`	`+`
	`120`	`+ auto& callees = callGraph[func];`
`116`	`121`	`for (Name callee : info.calledFunctions) {`
`117`		`- callGraph[func].insert(module.getFunction(callee));`
	`122`	`+ callees.insert(module.getFunction(callee));`
`118`	`123`	`}`
`119`	`124`	`}`
`120`	`125`