fix logic bug with ||,&& when deciding to emit a null. only emit a null when nullable..

kripken · kripken · commit 64ab85164add · 2025-08-18T12:37:36.000-07:00
diff --git a/src/tools/fuzzing/fuzzing.cpp b/src/tools/fuzzing/fuzzing.cpp
@@ -3470,7 +3470,8 @@ Expression* TranslateToFuzzReader::makeBasicRef(Type type) {
       return makeRefFuncConst(type);
     }
     case HeapType::cont: {
-      if (type.isNullable() || oneIn(4)) {
+      // Most of the time, avoid null continuations, as they will trap.
+      if (type.isNullable() && oneIn(4)) {
         return builder.makeRefNull(HeapTypes::cont.getBasic(share));
       }
       // Emit the simplest possible continuation.

Original file line number	Diff line number	Diff line change
`@@ -3470,7 +3470,8 @@ Expression* TranslateToFuzzReader::makeBasicRef(Type type) {`
`3470`	`3470`	`return makeRefFuncConst(type);`
`3471`	`3471`	`}`
`3472`	`3472`	`case HeapType::cont: {`
`3473`		`- if (type.isNullable() \|\| oneIn(4)) {`
	`3473`	`+ // Most of the time, avoid null continuations, as they will trap.`
	`3474`	`+ if (type.isNullable() && oneIn(4)) {`
`3474`	`3475`	`return builder.makeRefNull(HeapTypes::cont.getBasic(share));`
`3475`	`3476`	`}`
`3476`	`3477`	`// Emit the simplest possible continuation.`