fix(component): use technical user for background updates

The scheduled updates should get a proper user in the history.

Fixes #20108

Author: nijel

weblate/trans/models/component.py

@@ -1724,13 +1724,16 @@ def unload_sources(self) -> None:
         self._sources = {}
         self._sources_prefetched = False
 
-    def _process_new_source(self, source: Unit, *, save: bool = True) -> Change:
+    def _process_new_source(
+        self, source: Unit, *, save: bool = True, user: User | None = None
+    ) -> Change:
         # Avoid fetching empty list of checks from the database
         source.all_checks = []
         source.source_updated = True
+        user = user or self.acting_user
         change = source.generate_change(
-            self.acting_user,
-            self.acting_user,
+            user,
+            user,
             ActionEvents.NEW_SOURCE,
             check_new=False,
             save=save,
@@ -1743,6 +1746,7 @@ def bulk_create_sources(
         attributes_list: list[UnitAttributesDict],
         *,
         create_unit_change_action: ActionEvents = ActionEvents.NEW_UNIT_REPO,
+        user: User | None = None,
     ) -> None:
         """Ensure that all sources are stored in the database."""
         # Make sure we load all the sources
@@ -1792,7 +1796,7 @@ def bulk_create_sources(
             self._sources[unit.id_hash] = unit
 
             # Postprocess and create change
-            change = self._process_new_source(unit, save=False)
+            change = self._process_new_source(unit, save=False, user=user)
             if create_unit_change_action == ActionEvents.NEW_UNIT_UPLOAD:
                 change.action = ActionEvents.NEW_SOURCE_UPLOAD
             elif create_unit_change_action == ActionEvents.NEW_UNIT_REPO:
@@ -2339,6 +2343,7 @@ def needs_commit_upstream(self) -> bool:
     @perform_on_link
     def do_update(self, request: AuthenticatedHttpRequest | None = None, method=None):
         """Perform repository update."""
+        user = self.get_update_user(request)
         self.translations_progress = 0
         self.translations_count = 0
         # Hold lock all time here to avoid somebody writing between commit
@@ -2368,9 +2373,7 @@ def do_update(self, request: AuthenticatedHttpRequest | None = None, method=None
 
             # commit possible pending changes if needed
             if self.needs_commit_upstream():
-                self.commit_pending(
-                    "update", request.user if request else None, skip_push=True
-                )
+                self.commit_pending("update", user, skip_push=True)
 
             # update local branch
             try:
@@ -2379,6 +2382,7 @@ def do_update(self, request: AuthenticatedHttpRequest | None = None, method=None
                     method=method,
                     skip_push=True,
                     parse_after_update=True,
+                    user=user,
                 )
             except RepositoryError:
                 result = False
@@ -2387,7 +2391,7 @@ def do_update(self, request: AuthenticatedHttpRequest | None = None, method=None
             # create translation objects for all files
             parse_error = None
             try:
-                self.create_translations(request=request)
+                self.create_translations(request=request, user=user)
             except FileParseError as error:
                 parse_error = error
 
@@ -2404,6 +2408,19 @@ def do_update(self, request: AuthenticatedHttpRequest | None = None, method=None
 
         return result
 
+    def get_update_user(self, request: AuthenticatedHttpRequest | None) -> User:
+        """Return user to credit for background update events."""
+        user = request.user if request else self.acting_user
+        if user is not None:
+            return user
+
+        # ruff: ignore[import-outside-top-level]
+        from weblate.auth.models import User
+
+        return User.objects.get_or_create_bot(
+            scope="weblate", name="update", verbose="Background update"
+        )
+
     @perform_on_link
     def push_if_needed(self, do_update=True) -> None:
         """
@@ -3436,11 +3453,13 @@ def update_branch(
         method: str | None = None,
         skip_push: bool = False,
         parse_after_update: bool = False,
+        user: User | None = None,
     ) -> bool:
         """Update current branch to match remote (if possible)."""
         if method is None:
             method = self.merge_style
-        user = request.user if request else self.acting_user
+        if user is None:
+            user = request.user if request else self.acting_user
         # run pre update hook
         vcs_pre_update.send(sender=self.__class__, component=self)
         for component in self.linked_children:
@@ -3779,6 +3798,7 @@ def create_translations(
         force_scan: bool = False,
         langs: list[str] | None = None,
         request: AuthenticatedHttpRequest | None = None,
+        user: User | None = None,
         changed_template: bool = False,
         from_link: bool = False,
         change: int | None = None,
@@ -3793,6 +3813,7 @@ def create_translations(
                 force_scan=force_scan,
                 langs=langs,
                 request=request,
+                user=user,
                 changed_template=changed_template,
                 from_link=from_link,
                 change=change,
@@ -3807,6 +3828,7 @@ def create_translations(
                     force_scan=force_scan,
                     langs=langs,
                     request=request,
+                    user=user,
                     changed_template=changed_template,
                     from_link=from_link,
                     change=change,
@@ -3819,6 +3841,7 @@ def create_translations(
         # ruff: ignore[import-outside-top-level]
         from weblate.trans.tasks import perform_load
 
+        load_user = user or (request.user if request is not None else None)
         self.queue_background_task(
             perform_load,
             pk=self.pk,
@@ -3828,7 +3851,7 @@ def create_translations(
             changed_template=changed_template,
             from_link=from_link,
             change=change,
-            user_id=request.user.id if request is not None else None,
+            user_id=load_user.id if load_user is not None else None,
         )
         return False
 
@@ -3839,6 +3862,7 @@ def create_translations_immediate(
         force_scan: bool = False,
         langs: list[str] | None = None,
         request: AuthenticatedHttpRequest | None = None,
+        user: User | None = None,
         changed_template: bool = False,
         from_link: bool = False,
         change: int | None = None,
@@ -3859,6 +3883,7 @@ def create_translations_immediate(
                 force_scan=force_scan,
                 langs=langs,
                 request=request,
+                user=user,
                 changed_template=changed_template,
                 from_link=from_link,
                 change=change,
@@ -3891,6 +3916,7 @@ def _create_translations(  # ruff: ignore[complex-structure, too-many-statements
         force_scan: bool = False,
         langs: list[str] | None = None,
         request: AuthenticatedHttpRequest | None = None,
+        user: User | None = None,
         changed_template: bool = False,
         from_link: bool = False,
         change: int | None = None,
@@ -3899,6 +3925,8 @@ def _create_translations(  # ruff: ignore[complex-structure, too-many-statements
         # ruff: ignore[import-outside-top-level]
         from weblate.trans.tasks import update_enforced_checks
 
+        user = user or (request.user if request else self.acting_user)
+
         self.store_background_task()
 
         # Store the revision as add-ons might update it later
@@ -3994,6 +4022,7 @@ def _create_translations(  # ruff: ignore[complex-structure, too-many-statements
                         path,
                         force,
                         request=request,
+                        user=user,
                         change=change,
                     )
                 except InvalidTemplateError as error:
@@ -4031,7 +4060,6 @@ def _create_translations(  # ruff: ignore[complex-structure, too-many-statements
                         "removing stale translations: %s",
                         ",".join(trans.language.code for trans in todelete),
                     )
-                    user = self.acting_user or (request.user if request else None)
                     Change.objects.bulk_create(
                         Change(
                             component=self,
@@ -4073,6 +4101,7 @@ def _create_translations(  # ruff: ignore[complex-structure, too-many-statements
                     force_scan=force_scan,
                     langs=langs,
                     request=request,
+                    user=user,
                     from_link=True,
                 )
             except FileParseError as error:

weblate/trans/models/translation.py

@@ -140,6 +140,7 @@ def check_sync(
         path,
         force=False,
         request: AuthenticatedHttpRequest | None = None,
+        user: User | None = None,
         change=None,
     ):
         """Parse translation meta info and updates translation object."""
@@ -153,7 +154,7 @@ def check_sync(
             translation.language_code = code
             translation.save(update_fields=["filename", "language_code"])
         force |= translation.sync_readonly_check_flag()
-        translation.check_sync(force, request=request, change=change)
+        translation.check_sync(force, request=request, change=change, author=user)
         return translation
 
 
@@ -665,6 +666,7 @@ def update_units_from_store(  # ruff: ignore[complex-structure]
                         if newunit.unit_attributes is not None
                     ],
                     create_unit_change_action=self.create_unit_change_action,
+                    user=author or user,
                 )
 
         # Create/update translations
@@ -697,7 +699,7 @@ def check_sync(
         with start_span(op="translation.check_sync", name=self.full_slug):
             if change is None:
                 change = ActionEvents.UPDATE
-            user = None if request is None else request.user
+            user = request.user if request is not None else author
 
             details = {
                 "filename": self.filename,

weblate/trans/tasks.py

@@ -111,9 +111,11 @@ def perform_load(
     user_id: int | None = None,
 ) -> None:
     request: AuthenticatedHttpRequest | None = None
+    user: User | None = None
     if user_id:
+        user = User.objects.get(pk=user_id)
         request = AuthenticatedHttpRequest()
-        request.user = User.objects.get(pk=user_id)
+        request.user = user
     try:
         component = Component.objects.get(pk=pk)
     except Component.DoesNotExist:
@@ -127,6 +129,7 @@ def perform_load(
         from_link=from_link,
         change=change,
         request=request,
+        user=user,
     )
 
 

weblate/trans/tests/test_component.py

@@ -1537,6 +1537,7 @@ def test_create_translations_runs_immediately_inside_celery_task(self) -> None:
             force_scan=False,
             langs=None,
             request=request,
+            user=None,
             changed_template=False,
             from_link=False,
             change=None,

weblate/trans/tests/test_remote.py

@@ -129,6 +129,14 @@ def test_background_push_uses_bot_user(self) -> None:
         self.assertTrue(change.user.is_bot)
         self.assertEqual(change.user.full_name, "Background push")
 
+    def assert_background_update_user(self, change) -> None:
+        self.assertIsNotNone(change.user)
+        self.assertEqual(change.user.username, "weblate:update")
+        self.assertTrue(change.user.is_bot)
+        self.assertEqual(change.user.full_name, "Background update")
+        self.assertIsNotNone(change.author)
+        self.assertEqual(change.author.username, "weblate:update")
+
     def do_update_with_callbacks(self, translation) -> bool:
         translation = type(translation).objects.get(pk=translation.pk)
         with self.captureOnCommitCallbacks(execute=True):
@@ -194,6 +202,24 @@ def test_update(self) -> None:
         self.do_update_with_callbacks(translation)
         translation = self.component2.translation_set.get(language_code="cs")
         self.assertEqual(translation.stats.translated, 1)
+        change = translation.change_set.filter(action=ActionEvents.UPDATE).latest(
+            "timestamp"
+        )
+        self.assertEqual(change.user, self.user)
+        self.assertEqual(change.author, self.user)
+
+    def test_background_update_uses_bot_user(self) -> None:
+        """Test background update attribution in case remote has changed."""
+        self.push_first(False)
+
+        self.assertTrue(self.component2.do_update(None))
+
+        translation = self.component2.translation_set.get(language_code="cs")
+        self.assertEqual(translation.stats.translated, 1)
+        change = translation.change_set.filter(action=ActionEvents.UPDATE).latest(
+            "timestamp"
+        )
+        self.assert_background_update_user(change)
 
     def test_rebase(self) -> None:
         """Testing of rebase."""
@@ -237,6 +263,30 @@ def test_new_unit(self) -> None:
 
         translation = self.component2.translation_set.get(language_code="cs")
         self.assertEqual(translation.stats.all, 5)
+        unit = translation.unit_set.get(source="Languages")
+        change = unit.source_unit.change_set.filter(
+            action=ActionEvents.NEW_SOURCE_REPO
+        ).latest("timestamp")
+        self.assertEqual(change.user, self.user)
+        self.assertEqual(change.author, self.user)
+
+    def test_background_new_unit_update_uses_bot_user(self) -> None:
+        """Test background update attribution for units added in a repository."""
+        self.push_replace(EXTRA_PO, "a")
+
+        self.assertTrue(self.component2.do_update(None))
+
+        translation = self.component2.translation_set.get(language_code="cs")
+        self.assertEqual(translation.stats.all, 5)
+        unit = translation.unit_set.get(source="Languages")
+        change = unit.change_set.filter(action=ActionEvents.NEW_UNIT_REPO).latest(
+            "timestamp"
+        )
+        self.assert_background_update_user(change)
+        change = unit.source_unit.change_set.filter(
+            action=ActionEvents.NEW_SOURCE_REPO
+        ).latest("timestamp")
+        self.assert_background_update_user(change)
 
     def test_deleted_unit(self) -> None:
         """Test removing several units from remote repo."""