fix(component): properly log translation removals from the repo

The repository-originated translation removals were invisible in the history.

See #20088

Author: nijel

weblate/trans/models/component.py

@@ -3996,15 +3996,32 @@ def _create_translations(  # ruff: ignore[complex-structure, too-many-statements
 
         # Delete possibly no longer existing translations
         if langs is None:
-            todelete = self.translation_set.exclude(id__in=translations.keys())
-            if todelete.exists():
+            todelete = list(
+                self.translation_set.exclude(id__in=translations.keys()).select_related(
+                    "language"
+                )
+            )
+            if todelete:
                 self.needs_cleanup = True
                 with transaction.atomic():
                     self.log_info(
                         "removing stale translations: %s",
                         ",".join(trans.language.code for trans in todelete),
                     )
-                    todelete.delete()
+                    user = self.acting_user or (request.user if request else None)
+                    Change.objects.bulk_create(
+                        Change(
+                            component=self,
+                            action=ActionEvents.REMOVE_TRANSLATION,
+                            target=translation.filename,
+                            user=user,
+                            author=user,
+                        )
+                        for translation in todelete
+                    )
+                    Translation.objects.filter(
+                        id__in=[translation.id for translation in todelete]
+                    ).delete()
                     # Indicate a change to invalidate stats
                     was_change = True
 

weblate/trans/tests/test_component.py

@@ -25,6 +25,7 @@
 from weblate.trans.actions import ActionEvents
 from weblate.trans.exceptions import FileParseError
 from weblate.trans.models import (
+    Change,
     CommitPolicyChoices,
     Component,
     PendingUnitChange,
@@ -2300,6 +2301,17 @@ def test_handle_restore_pending_translation_failure_without_translation(
 
 
 class ResetDiscardRevisionTest(ComponentTestCase):
+    def assert_removed_translation_change(self, filename: str) -> None:
+        change = Change.objects.get(
+            component=self.component,
+            action=ActionEvents.REMOVE_TRANSLATION,
+            target=filename,
+        )
+        self.assertEqual(change.user, self.user)
+        self.assertEqual(change.author, self.user)
+        self.assertEqual(change.project, self.project)
+        self.assertIsNone(change.translation_id)
+
     def test_reset_updates_stored_local_revision(self) -> None:
         start_rev = self.component.repository.last_revision
 
@@ -2317,6 +2329,43 @@ def test_reset_updates_stored_local_revision(self) -> None:
         self.assertEqual(start_rev, self.component.repository.last_revision)
         self.assertEqual(start_rev, self.component.local_revision)
 
+    def test_file_scan_removes_stale_translation_with_change(self) -> None:
+        translation = self.component.translation_set.get(language_code="cs")
+        filename = translation.filename
+        pathlib.Path(cast("str", translation.get_filename())).unlink()
+
+        self.assertTrue(
+            self.component.create_translations_immediate(
+                force=True, request=self.get_request()
+            )
+        )
+
+        self.assertFalse(
+            self.component.translation_set.filter(language_code="cs").exists()
+        )
+        self.assert_removed_translation_change(filename)
+        self.assertFalse(self.project.has_language(Language.objects.get(code="cs")))
+
+    def test_reset_removes_upstream_deleted_translation_with_change(self) -> None:
+        translation = self.component.translation_set.get(language_code="cs")
+        filename = translation.filename
+
+        with self.component.repository.lock:
+            self.component.repository.remove([filename], "Remove Czech translation")
+            self.component.repository.push(self.component.push_branch)
+
+        self.assertTrue(
+            self.component.translation_set.filter(language_code="cs").exists()
+        )
+
+        self.assertTrue(self.component.do_reset(self.get_request()))
+
+        self.assertFalse(
+            self.component.translation_set.filter(language_code="cs").exists()
+        )
+        self.assert_removed_translation_change(filename)
+        self.assertFalse(self.project.has_language(Language.objects.get(code="cs")))
+
 
 class TranslationRemoveRevisionTest(ComponentTestCase):
     def test_remove_updates_stored_local_revision(self) -> None:
@@ -2333,6 +2382,22 @@ def test_remove_updates_stored_local_revision(self) -> None:
             self.component.local_revision, self.component.repository.last_revision
         )
 
+    def test_remove_creates_change(self) -> None:
+        translation = self.component.translation_set.get(language_code="de")
+        filename = translation.filename
+
+        translation.remove(self.user)
+
+        change = Change.objects.get(
+            component=self.component,
+            action=ActionEvents.REMOVE_TRANSLATION,
+            target=filename,
+        )
+        self.assertEqual(change.user, self.user)
+        self.assertEqual(change.author, self.user)
+        self.assertEqual(change.project, self.project)
+        self.assertIsNone(change.translation_id)
+
 
 class LastCommitLookupTest(ComponentTestCase):
     def test_get_last_commit_keeps_stale_local_revision_unchanged(self) -> None: