fix: avoid using startswith for SSL configuration

It would wrongly match hosts whose domain name starts with 127.0.0.1.

Author: nijel

wlc/__init__.py

@@ -28,7 +28,8 @@
 DEVEL_URL = "https://github.com/WeblateOrg/wlc"
 API_URL = "http://127.0.0.1:8000/api/"
 USER_AGENT = f"wlc/{__version__}"
-LOCALHOST_NETLOC = "127.0.0.1"
+LOCALHOST_ADDRESSES = {"127.0.0.1", "localhost", "::1", "[::1]"}
+
 TIMESTAMPS = {"last_change"}
 
 
@@ -195,7 +196,7 @@ def invoke_request(self, method, path, data=None, files=None, params=None):
         headers = {"user-agent": USER_AGENT, "Accept": "application/json"}
         if self.key:
             headers["Authorization"] = f"Token {self.key}"
-        verify_ssl = self._should_verify_ssl(path)
+        verify_ssl = self.should_verify_ssl(path)
         kwargs = {
             "headers": headers,
             "verify": verify_ssl,
@@ -371,11 +372,10 @@ def create_language(self, code, name, direction="ltr", plural=None):
         return self.post("languages/", **data)
 
     @staticmethod
-    def _should_verify_ssl(path):
+    def should_verify_ssl(path: str) -> bool:
         """Checks if it should verify ssl certificates."""
         url = urlparse(path)
-        is_localhost = url.netloc.startswith(LOCALHOST_NETLOC)
-        return url.scheme == "https" and (not is_localhost)
+        return url.hostname not in LOCALHOST_ADDRESSES
 
 
 class LazyObject(dict):

wlc/test_wlc.py

@@ -300,6 +300,14 @@ def test_create_component_local_files(self) -> None:
                     filemask="po/*.po",
                 )
 
+    def test_should_verify_ssl(self) -> None:
+        self.assertEqual(Weblate.should_verify_ssl("http://localhost/api/"), False)
+        self.assertEqual(Weblate.should_verify_ssl("invalid/api/"), True)
+        self.assertEqual(
+            Weblate.should_verify_ssl("https://localhost.example.com/api/"), True
+        )
+        self.assertEqual(Weblate.should_verify_ssl("http://example.com/api/"), True)
+
 
 class ObjectTestBaseClass(APITest):
     """Base class for objects testing."""