Skip to content

Commit 92bc67d

Browse files
committed
Framework: Re-pin to newer version of JSDOM
Newer version is SemVer-compatible with jest-environment-jsdom and includes support for Element#closest out of the box. jsdom/jsdom#1555 Required to ignore license validation for abab because while it is a compatible license (BSD 3-clause), the package's `license` field is malformed for parse. https://github.com/jsdom/abab/blob/4327de3aae348710094d9f3c1f0c1477d9feb865/package.json#L26 https://github.com/jsdom/abab/blob/master/LICENSE.md
1 parent 68bc9e7 commit 92bc67d

5 files changed

Lines changed: 44 additions & 55 deletions

File tree

package-lock.json

Lines changed: 43 additions & 45 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@
157157
"build:packages": "cross-env EXCLUDE_PACKAGES=babel-plugin-import-jsx-pragma,jest-console,postcss-themes node ./bin/packages/build.js",
158158
"build": "npm run build:packages && cross-env NODE_ENV=production webpack",
159159
"check-engines": "check-node-version --package",
160-
"check-licenses": "concurrently \"wp-scripts check-licenses --prod --gpl2\" \"wp-scripts check-licenses --dev\"",
160+
"check-licenses": "concurrently \"wp-scripts check-licenses --prod --gpl2 --ignore=abab\" \"wp-scripts check-licenses --dev --ignore=abab\"",
161161
"ci": "concurrently \"npm run lint\" \"npm run test-unit:coverage-ci\"",
162162
"predev": "npm run check-engines",
163163
"dev": "npm run build:packages && concurrently \"cross-env webpack --watch\" \"npm run dev:packages\"",

packages/jest-preset-default/CHANGELOG.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,3 @@
1-
## 2.1.0 (Unreleased)
2-
3-
### New Features
4-
5-
- Browser globals setup now includes polyfill for [`Element#closest`](https://developer.mozilla.org/en-US/docs/Web/API/Element/closest)
6-
71
## 2.0.0 (2018-07-12)
82

93
### Breaking Change

packages/jest-preset-default/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
"dependencies": {
2929
"@wordpress/jest-console": "file:../jest-console",
3030
"babel-jest": "^23.4.2",
31-
"element-closest": "^2.0.2",
3231
"enzyme": "^3.3.0",
3332
"enzyme-adapter-react-16": "^1.1.1",
3433
"jest-enzyme": "^6.0.2"

packages/jest-preset-default/scripts/setup-globals.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
require( 'element-closest' );
2-
31
// These are necessary to load TinyMCE successfully
42
global.URL = window.URL;
53
global.window.tinyMCEPreInit = {

0 commit comments

Comments
 (0)