Skip to content

Commit 4591723

Browse files
Connectors: Update wp_get_connectors() tests for the Akismet default.
The default connector registry now includes Akismet, which is a `spam_filtering` connector that uses the legacy `wordpress_api_key` option. Update the test expectations to allow non-AI connector types and skip the AI-specific `connectors_ai_{id}_api_key` setting-name format check for them.
1 parent f2f2d83 commit 4591723

1 file changed

Lines changed: 11 additions & 4 deletions

File tree

tests/phpunit/tests/connectors/wpConnectorsGetConnectorSettings.php

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,9 @@ public function test_returns_expected_connector_keys(): void {
3737
$this->assertArrayHasKey( 'google', $connectors );
3838
$this->assertArrayHasKey( 'openai', $connectors );
3939
$this->assertArrayHasKey( 'anthropic', $connectors );
40+
$this->assertArrayHasKey( 'akismet', $connectors );
4041
$this->assertArrayHasKey( 'mock-connectors-test', $connectors );
41-
$this->assertCount( 4, $connectors );
42+
$this->assertCount( 5, $connectors );
4243
}
4344

4445
/**
@@ -56,7 +57,7 @@ public function test_each_connector_has_required_fields(): void {
5657
$this->assertArrayHasKey( 'description', $connector_data, "Connector '{$connector_id}' is missing 'description'." );
5758
$this->assertIsString( $connector_data['description'], "Connector '{$connector_id}' description should be a string." );
5859
$this->assertArrayHasKey( 'type', $connector_data, "Connector '{$connector_id}' is missing 'type'." );
59-
$this->assertContains( $connector_data['type'], array( 'ai_provider' ), "Connector '{$connector_id}' has unexpected type '{$connector_data['type']}'." );
60+
$this->assertContains( $connector_data['type'], array( 'ai_provider', 'spam_filtering' ), "Connector '{$connector_id}' has unexpected type '{$connector_data['type']}'." );
6061
$this->assertArrayHasKey( 'authentication', $connector_data, "Connector '{$connector_id}' is missing 'authentication'." );
6162
$this->assertIsArray( $connector_data['authentication'], "Connector '{$connector_id}' authentication should be an array." );
6263
$this->assertArrayHasKey( 'method', $connector_data['authentication'], "Connector '{$connector_id}' authentication is missing 'method'." );
@@ -79,10 +80,16 @@ public function test_api_key_connectors_have_setting_name_and_credentials_url():
7980
++$api_key_count;
8081

8182
$this->assertArrayHasKey( 'setting_name', $connector_data['authentication'], "Connector '{$connector_id}' authentication is missing 'setting_name'." );
83+
$this->assertNotEmpty( $connector_data['authentication']['setting_name'], "Connector '{$connector_id}' setting_name should not be empty." );
84+
85+
if ( 'ai_provider' !== $connector_data['type'] ) {
86+
continue;
87+
}
88+
8289
$this->assertSame(
8390
'connectors_ai_' . str_replace( '-', '_', $connector_id ) . '_api_key',
84-
$connector_data['authentication']['setting_name'] ?? null,
85-
"Connector '{$connector_id}' setting_name does not match expected format."
91+
$connector_data['authentication']['setting_name'],
92+
"Connector '{$connector_id}' setting_name does not match expected AI provider format."
8693
);
8794
}
8895

0 commit comments

Comments
 (0)