Revert URL encoding when fetching lineage (MarquezProject#2529)

* Revert URL encoding

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* comment

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Add a test

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

---------

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
Signed-off-by: Xavier-Cliquennois <Xavier-Cliquennois@users.noreply.github.com>

Author: jlukenoff

web/src/__tests__/requests/lineage.test.ts

@@ -0,0 +1,22 @@
+// Copyright 2018-2023 contributors to the Marquez project
+// SPDX-License-Identifier: Apache-2.0
+
+import { generateNodeId } from '../../helpers/nodes'
+import * as requestUtils from '../../store/requests'
+import { getLineage } from '../../store/requests/lineage'
+
+describe('getLineage function', () => {
+  let spy: jest.SpyInstance<Promise<any>, [string, requestUtils.IParams, string]>
+  let testResult: Promise<any>
+
+  beforeEach(() => {
+    spy = jest.spyOn(requestUtils, 'genericFetchWrapper').mockImplementation(() => {})
+    testResult = getLineage('JOB', 'foo', 'bar', 0)
+  })
+
+  it('does not url-encode query params', () => {
+    const expectedNodeId = generateNodeId('JOB', 'foo', 'bar')
+    const actualParamString = spy.mock.lastCall[0].split('?')
+    expect(actualParamString.pop()!.split('&')).toContain(`nodeId=${expectedNodeId}`)
+  })
+})

web/src/store/requests/index.ts

@@ -8,7 +8,7 @@ export const genericErrorMessageConstructor = (functionName: string, error: APIE
   throw `${functionName} responded with error code ${code}: ${message}.  Here are the details: ${details}`
 }
 
-interface IParams {
+export interface IParams {
   method: HttpMethod
   body?: string
 }

web/src/store/requests/lineage.ts

@@ -12,10 +12,8 @@ export const getLineage = async (
   name: string,
   depth: number
 ) => {
-  const params = new URLSearchParams({
-    nodeId: generateNodeId(nodeType, namespace, name),
-    depth: depth.toString()
-  })
-  const url = `${API_URL}/lineage/?${params.toString()}`
+  const nodeId = generateNodeId(nodeType, namespace, name)
+  // Node ID cannot be URL encoded
+  const url = `${API_URL}/lineage/?nodeId=${nodeId}&depth=${depth}`
   return genericFetchWrapper(url, { method: 'GET' }, 'fetchLineage')
 }