Stop generating State<T> fluent overloads

Author: xoofx

src/XenoAtom.Terminal.UI.SourceGen/TerminalUiGenerator.cs

@@ -986,71 +986,6 @@ private static string GenerateFluentExtensionsSource(INamedTypeSymbol containing
                         sb.AppendLine();
                     }
 
-                    sb.Append(methodIndent).AppendLine("/// <summary>");
-                    sb.Append(methodIndent).Append("/// Configures <see cref=\"").Append(receiverTypeXml).Append('.').Append(EscapeIdentifier(propName)).AppendLine("\"/> from a <see cref=\"global::XenoAtom.Terminal.UI.State{T}\"/> and returns the same instance.");
-                    sb.Append(methodIndent).AppendLine("/// </summary>");
-                    sb.Append(methodIndent).AppendLine("/// <param name=\"obj\">The instance to configure.</param>");
-                    sb.Append(methodIndent).Append("/// <param name=\"").Append(EscapeIdentifier(argName)).AppendLine("\">The state providing the current value.</param>");
-                    sb.Append(methodIndent).AppendLine("/// <returns>The same instance for chaining.</returns>");
-                    sb.Append(methodIndent).AppendLine("[global::System.CodeDom.Compiler.GeneratedCode(\"XenoAtom.Terminal.UI.SourceGen\", \"0.1.0\")]");
-                    if (p.GenerateImplementation)
-                    {
-                        if (canUseGeneric)
-                        {
-                            sb.Append(methodIndent).Append("public static T ").Append(EscapeIdentifier(propName)).Append("<T>(this T obj, global::XenoAtom.Terminal.UI.State<").Append(argType).Append("> ").Append(EscapeIdentifier(argName))
-                                .Append(") where T : ").Append(receiverType).AppendLine();
-                            sb.Append(methodIndent).Append("    => ").Append(EscapeIdentifier(propName)).Append("(obj, (global::XenoAtom.Terminal.UI.Binding<").Append(argType).Append(">)").Append(EscapeIdentifier(argName)).AppendLine(");");
-                        }
-                        else
-                        {
-                            sb.Append(methodIndent).Append("public static ").Append(receiverType).Append(' ').Append(EscapeIdentifier(propName));
-                            if (needsTypeParameters)
-                            {
-                                AppendTypeParameters(sb, containingType);
-                            }
-                            sb.Append("(this ").Append(receiverType).Append(" obj, global::XenoAtom.Terminal.UI.State<")
-                                .Append(argType).Append("> ").Append(EscapeIdentifier(argName)).Append(')');
-                            if (needsTypeParameters)
-                            {
-                                AppendTypeParameterConstraints(sb, containingType, methodIndent);
-                            }
-                            else
-                            {
-                                sb.AppendLine();
-                            }
-                            sb.Append(methodIndent).Append("    => ").Append(EscapeIdentifier(propName)).Append("(obj, (global::XenoAtom.Terminal.UI.Binding<").Append(argType).Append(">)").Append(EscapeIdentifier(argName)).AppendLine(");");
-                        }
-                    }
-                    else
-                    {
-                        if (canUseGeneric)
-                        {
-                            sb.Append(methodIndent).Append("public static T ").Append(EscapeIdentifier(propName)).Append("<T>(this T obj, global::XenoAtom.Terminal.UI.State<").Append(argType).Append("> ").Append(EscapeIdentifier(argName))
-                                .Append(") where T : ").Append(receiverType).AppendLine();
-                            sb.Append(methodIndent).Append("    => ").Append(EscapeIdentifier(propName)).Append("(obj, () => ").Append(EscapeIdentifier(argName)).AppendLine(".Value);");
-                        }
-                        else
-                        {
-                            sb.Append(methodIndent).Append("public static ").Append(receiverType).Append(' ').Append(EscapeIdentifier(propName));
-                            if (needsTypeParameters)
-                            {
-                                AppendTypeParameters(sb, containingType);
-                            }
-                            sb.Append("(this ").Append(receiverType).Append(" obj, global::XenoAtom.Terminal.UI.State<")
-                                .Append(argType).Append("> ").Append(EscapeIdentifier(argName)).Append(')');
-                            if (needsTypeParameters)
-                            {
-                                AppendTypeParameterConstraints(sb, containingType, methodIndent);
-                            }
-                            else
-                            {
-                                sb.AppendLine();
-                            }
-                            sb.Append(methodIndent).Append("    => ").Append(EscapeIdentifier(propName)).Append("(obj, () => ").Append(EscapeIdentifier(argName)).AppendLine(".Value);");
-                        }
-                    }
-
-                    sb.AppendLine();
                 }
             }
 

src/XenoAtom.Terminal.UI.Tests/TerminalUiGeneratorTests.cs

@@ -82,7 +82,8 @@ public sealed class PointerPressedEventArgs : RoutedEventArgs
         Assert.IsTrue(generatedSources.Any(s => s.Contains("__Title__BindingAccessor", StringComparison.Ordinal)), "Expected generated accessor for custom bindable property.");
         Assert.IsFalse(generatedSources.Any(s => s.Contains("private global::System.String _title", StringComparison.Ordinal)), "Did not expect generated backing field for custom bindable property.");
         Assert.IsTrue(generatedSources.Any(s => s.Contains("PointerPressedEvent", StringComparison.Ordinal)), "Expected generated routed event field.");
-        Assert.IsTrue(generatedSources.Any(s => s.Contains("Count<T>(this T obj, global::XenoAtom.Terminal.UI.State<", StringComparison.Ordinal)), "Expected generated fluent overloads for State<T>.");
+        Assert.IsTrue(generatedSources.Any(s => s.Contains("Count<T>(this T obj, global::XenoAtom.Terminal.UI.Binding<int>", StringComparison.Ordinal)), "Expected generated fluent overloads for Binding<T>.");
+        Assert.IsFalse(generatedSources.Any(s => s.Contains("Count<T>(this T obj, global::XenoAtom.Terminal.UI.State<", StringComparison.Ordinal)), "Did not expect generated fluent overloads for State<T>.");
     }
 
     [TestMethod]