feat: move to github docker registry

Author: Cybertron01Z

.cursor/rules/poinz.mdc

@@ -1,12 +1,14 @@
 ---
 description: 
-globs: client/**/*.js,client/**/*.jsx
-alwaysApply: false
+globs: 
+alwaysApply: true
 ---
 # Poinz rules
 
 - we are still using javascript
 - if you are working on a js file, do not create a ts file, do everything in the javascript file
 - if you are creating new files you must use typescript
 
-- NEVER FINISH BEFORE YOU ARE NOT FINISHED, I DO NOT WANT TO HEAR "should I continue?"
+- NEVER FINISH BEFORE YOU ARE NOT FINISHED, I DO NOT WANT TO HEAR "should I continue?"
+
+- DO NOT EVER SUMMARISE WHAT YOU DID, I SEE IT IN THE CODE CHANGES

.github/workflows/development.yml

@@ -28,4 +28,7 @@ jobs:
         run: npm test
 
       - name: build app & docker image
+        env:
+          DOCKER_REGISTRY: ghcr.io
+          DOCKER_USERNAME: ${{ github.repository_owner }}
         run: npm run build:dockerImage

.github/workflows/master.yml

@@ -12,6 +12,9 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      packages: write
 
     steps:
       - uses: actions/checkout@v3
@@ -28,15 +31,21 @@ jobs:
       - name: run all tests
         run: npm test
 
+      - name: Log in to GitHub Container Registry
+        uses: docker/login-action@v3
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
       - name: build app & docker image
+        env:
+          DOCKER_REGISTRY: ghcr.io
+          DOCKER_USERNAME: ${{ github.repository_owner }}
         run: npm run build:dockerImage
 
-      # push docker image to repo (the --all-tags flag was introduced in version v20.10, older versions pushed all images automatically if no tag was provided)
-      - name: push docker image
+      - name: Push Docker image
         env:
-          DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
-          DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
+          DOCKER_USERNAME: ${{ github.repository_owner }}
         run: |
-          docker -v;
-          echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin;
-          docker image push --all-tags "${DOCKER_USERNAME}/poinz" || docker image push "${DOCKER_USERNAME}/poinz";
+          docker image push --all-tags "ghcr.io/${DOCKER_USERNAME,,}/poinz" || docker image push "ghcr.io/${DOCKER_USERNAME,,}/poinz"

build/dockerImage.mjs

@@ -33,19 +33,23 @@ async function buildImage() {
     } (git-tags: ${gitInfo.tags.join(' ')})`
   );
 
-  const user = process.env.DOCKER_USERNAME || 'xeronimus';
-  const userAndProject = `${user}/poinz`;
+  if (!process.env.DOCKER_REGISTRY) {
+    throw new Error('DOCKER_REGISTRY environment variable must be set');
+  }
+  if (!process.env.DOCKER_USERNAME) {
+    throw new Error('DOCKER_USERNAME environment variable must be set');
+  }
+
+  const registry = process.env.DOCKER_REGISTRY;
+  const user = process.env.DOCKER_USERNAME.toLowerCase();
+  const userAndProject = `${registry}/${user}/poinz`;
   const tags = [`${userAndProject}:latest`, HEROKU_DEPLOYMENT_TAG];
   gitInfo.tags.forEach((gitTag) => tags.push(`${userAndProject}:${gitTag}`));
   const cmdArgs = `build ${tags.map((tg) => '-t ' + tg).join(' ')} --network=host .`;
 
-  console.log(` $ docker ${cmdArgs}`); // will be something like : docker build -t xeronimus/poinz:latest -t registry.heroku.com/poinz/web .
+  console.log(` $ docker ${cmdArgs}`);
 
   return spawnAndPrint('docker', cmdArgs.split(' '), {cwd: path.resolve(dirname, '..')});
-
-  console.log(
-    'Done.\ndocker run  -e NODE_ENV=development -p 3000:3000 --name poinz_local -d xeronimus/poinz'
-  );
 }
 
 function getGitInformation() {