File tree Expand file tree Collapse file tree
opentelemetry-sdk/src/opentelemetry/sdk/metrics Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -103,16 +103,16 @@ def add(self, value: metrics_api.ValueT) -> None:
103103 self .update (value )
104104
105105 def _validate_update (self , value : metrics_api .ValueT ) -> bool :
106- if super ()._validate_update (value ):
107- if value >= 0 :
108- return True
106+ if not super ()._validate_update (value ):
107+ return False
108+ if value < 0 :
109109 logger .warning (
110- "Invalid value %s passed to Counter, value must be "
111- "non-negative. For a Counter that can decrease, use "
112- "UpDownCounter." ,
110+ "Invalid value %s passed to Counter, value must be non-negative. "
111+ "For a Counter that can decrease, use UpDownCounter." ,
113112 value ,
114113 )
115- return False
114+ return False
115+ return True
116116
117117
118118class BoundUpDownCounter (metrics_api .BoundUpDownCounter , BaseBoundInstrument ):
You can’t perform that action at this time.
0 commit comments