Fix: Error when template_builder is overwritten (#232)

* Add check for if generator was overriden and use :erb if it was

* bump version

* Remove rails dependency and just automatically override

* Update install_generator

* Correctly override template engine option

* Ensure all generators that use :erb have correct override

* Update remaining generators

* Revert unnecessary change

Author: Tonksthebear

lib/active_agent/version.rb

@@ -1,3 +1,3 @@
 module ActiveAgent
-  VERSION = "0.6.1"
+  VERSION = "0.6.2"
 end

lib/generators/active_agent/agent_generator.rb

@@ -9,6 +9,14 @@ class AgentGenerator < ::Rails::Generators::NamedBase
 
       check_class_collision suffix: "Agent"
 
+      def initialize(*args, **kwargs)
+        super(*args, **kwargs)
+
+        # We must duplicate due to immutable hash
+        dup_options = options.dup
+        @options = dup_options.merge(template_engine: :erb)
+      end
+
       def create_agent_file
         template "agent.rb", File.join("app/agents", class_path, "#{file_name}_agent.rb")
 

lib/generators/active_agent/install_generator.rb

@@ -6,6 +6,14 @@ class InstallGenerator < ::Rails::Generators::Base
       class_option :skip_config, type: :boolean, default: false, desc: "Skip configuration file generation"
       class_option :formats, type: :array, default: [ "text" ], desc: "Specify formats to generate (text, html, json)"
 
+      def initialize(*args, **kwargs)
+        super(*args, **kwargs)
+
+        # We must duplicate due to immutable hash
+        dup_options = options.dup
+        @options = dup_options.merge(template_engine: :erb)
+      end
+
       def self.usage_path
         @usage_path ||= File.expand_path("../USAGE", __dir__)
       end
@@ -26,6 +34,7 @@ def create_application_agent
       hook_for :template_engine
 
       private
+
       def formats
         options[:formats].map(&:to_sym)
       end

lib/generators/erb/agent_generator.rb

@@ -9,6 +9,14 @@ class AgentGenerator < Base # :nodoc:
       argument :actions, type: :array, default: [], banner: "method method"
       class_option :formats, type: :array, default: [ "text" ], desc: "Specify formats to generate (text, html, json)"
 
+      def initialize(*args, **kwargs)
+        super(*args, **kwargs)
+
+        # We must duplicate due to immutable hash
+        dup_options = options.dup
+        @options = dup_options.merge(template_engine: :erb)
+      end
+
       def copy_view_files
         view_base_path = File.join("app/views", class_path, file_name + "_agent")
         empty_directory view_base_path

lib/generators/erb/install_generator.rb

@@ -6,6 +6,14 @@ class InstallGenerator < ::Rails::Generators::Base # :nodoc:
       source_root File.expand_path("templates", __dir__)
       class_option :formats, type: :array, default: [ "text" ], desc: "Specify formats to generate (text, html, json)"
 
+      def initialize(*args, **kwargs)
+        super(*args, **kwargs)
+
+        # We must duplicate due to immutable hash
+        dup_options = options.dup
+        @options = dup_options.merge(template_engine: :erb)
+      end
+
       def create_agent_layouts
         if behavior == :invoke
           formats.each do |format|

test/generators/active_agent/agent_generator_test.rb

@@ -146,6 +146,21 @@ class ActiveAgent::Generators::AgentGeneratorTest < Rails::Generators::TestCase
     assert_no_file "app/views/admin/user_agent/create.json.erb"
   end
 
+  test "handles erb generator override with proactive detection" do
+    original_template_engine = Rails::Generators.options[:rails][:template_engine]
+    Rails::Generators.options[:rails][:template_engine] = :nonexistent
+
+    begin
+      run_generator %w[user create --formats=html]
+
+      assert_file "app/agents/user_agent.rb"
+      assert_file "app/views/user_agent/create.html.erb"
+    ensure
+      # Restore original template engine
+      Rails::Generators.options[:rails][:template_engine] = original_template_engine
+    end
+  end
+
   private
 
   def create_file(path, content)

test/generators/active_agent/install_generator_test.rb

@@ -104,4 +104,19 @@ class ActiveAgent::Generators::InstallGeneratorTest < Rails::Generators::TestCas
     assert_no_file "app/views/layouts/agent.html.erb"
     assert_no_file "app/views/layouts/agent.json.erb"
   end
+
+  test "handles erb generator override with proactive detection" do
+    original_template_engine = Rails::Generators.options[:rails][:template_engine]
+    Rails::Generators.options[:rails][:template_engine] = :nonexistent
+
+    begin
+      run_generator
+
+      # Verify proactive detection created the layout file
+      assert_file "app/views/layouts/agent.text.erb"
+    ensure
+      # Restore original template engine
+      Rails::Generators.options[:rails][:template_engine] = original_template_engine
+    end
+  end
 end

test/generators/erb/agent_generator_test.rb

@@ -55,4 +55,18 @@ class Erb::Generators::AgentGeneratorTest < Rails::Generators::TestCase
     assert_directory "app/views/user_agent"
     assert_file "app/views/user_agent/instructions.text.erb"
   end
+
+  test "handles erb generator override with proactive detection" do
+    original_template_engine = Rails::Generators.options[:rails][:template_engine]
+    Rails::Generators.options[:rails][:template_engine] = :nonexistent
+
+    begin
+      run_generator %w[user create]
+
+      assert_file "app/views/user_agent/create.text.erb"
+    ensure
+      # Restore original template engine
+      Rails::Generators.options[:rails][:template_engine] = original_template_engine
+    end
+  end
 end

test/generators/erb/install_generator_test.rb

@@ -21,4 +21,18 @@ class Erb::Generators::InstallGeneratorTest < Rails::Generators::TestCase
       assert_match(/<%= yield %>/, content)
     end
   end
+
+  test "handles erb generator override with proactive detection" do
+    original_template_engine = Rails::Generators.options[:rails][:template_engine]
+    Rails::Generators.options[:rails][:template_engine] = :nonexistent
+
+    begin
+      run_generator [ "--formats=html" ]
+
+      assert_file "app/views/layouts/agent.html.erb"
+    ensure
+      # Restore original template engine
+      Rails::Generators.options[:rails][:template_engine] = original_template_engine
+    end
+  end
 end