Skip to content
This repository was archived by the owner on Sep 2, 2021. It is now read-only.

Commit f2f290d

Browse files
committed
Merge pull request #166 from le717/master
Remove "x" buttons from dialogs
2 parents cc63d99 + c2dbd0c commit f2f290d

10 files changed

Lines changed: 8 additions & 16 deletions

File tree

htmlContent/ewf-browse-dialog.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
<div class="edge-web-fonts-browse-dialog template modal hide">
22
<div class="modal-header">
3-
<a href="#" class="close">&times;</a>
43
<h1 class="dialog-title">{{PRODUCT_NAME}}</h1>
54
</div>
65
<div class="modal-body">
76
<div class="edge-web-fonts edge-web-fonts-browse-dialog-body"></div>
87
</div>
98
<div class="modal-footer">
109
<span class="ewf-terms-of-use">{{{TERMS_OF_USE}}}</span>
10+
<a href="#" class="dialog-button btn" data-button-id="cancel">{{CANCEL}}</a>
1111
<a href="#" class="dialog-button btn primary" data-button-id="ok">{{DIALOG_DONE}}</a>
1212
</div>
1313
</div>

htmlContent/ewf-howto-dialog.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<div class="edge-web-fonts-howto-dialog template modal hide">
22
<div class="modal-header">
3-
<a href="#" class="close">&times;</a>
43
<h1 class="dialog-title">{{Strings.PRODUCT_NAME}}</h1>
54
</div>
65
<div class="modal-body">

htmlContent/ewf-include-dialog.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<div class="edge-web-fonts-include-dialog template modal hide">
22
<div class="modal-header">
3-
<a href="#" class="close">&times;</a>
43
<h1 class="dialog-title">{{PRODUCT_NAME}}</h1>
54
</div>
65
<div class="modal-body">

main.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -223,8 +223,7 @@ define(function (require, exports, module) {
223223

224224
function _showHowtoDialog() {
225225
var dlg = Dialogs.showModalDialogUsingTemplate(ewfHowtoDialogTemplate);
226-
dlg.getElement().find(".close").on("click", dlg.close.bind(dlg));
227-
226+
228227
$(".edge-web-fonts-howto-diagram").css("background-image", "-webkit-image-set(url('" + howtoDiagramURL + "') 1x, url('" + howtoDiagramHiDPIURL + "') 2x)");
229228
}
230229

@@ -455,8 +454,7 @@ define(function (require, exports, module) {
455454
}
456455
editor.focus();
457456
});
458-
dlg.getElement().find(".close").on("click", dlg.close.bind(dlg));
459-
457+
460458
webfont.renderPicker($('.edge-web-fonts-browse-dialog.instance'));
461459

462460
$(webfont).on("ewfFontChosen", function () {
@@ -498,7 +496,6 @@ define(function (require, exports, module) {
498496
} else {
499497
includeString = webfont.createInclude(fontFamilies);
500498
var dlg = Dialogs.showModalDialogUsingTemplate(ewfIncludeDialogTemplate);
501-
dlg.getElement().find(".close").on("click", dlg.close.bind(dlg));
502499
$('.instance .ewf-include-string').html(StringUtils.htmlEscape(includeString)).focus().select();
503500
}
504501
}

nls/de/strings.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ define({
2828
"PRODUCT_NAME" : "Adobe Edge Web Fonts",
2929

3030
"DIALOG_DONE" : "Fertig",
31+
"CANCEL" : "Abbrechen",
3132
"SEARCH_PLACEHOLDER" : "Suchen",
3233
"BROWSE_FONTS_INSTRUCTIONS" : "Suchen und wählen Sie die Schrift, die Sie in ihrem Webprojekt integrieren möchten.",
3334
"CODEHINT_BROWSE" : "Web-Fonts durchsuchen...", // Needs to be short to fit in popup, but not sure about acronym

nls/fr/strings.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ define({
2828
"PRODUCT_NAME": "Edge Web Fonts",
2929

3030
"DIALOG_DONE": "Terminé",
31+
"CANCEL": "Annuler",
3132
"SEARCH_PLACEHOLDER": "Rechercher",
3233
"BROWSE_FONTS_INSTRUCTIONS": "Recherchez et sélectionnez la police Web que vous souhaitez inclure dans votre projet Web.",
3334
"CODEHINT_BROWSE": "Parcourir les polices Web...",

nls/ja/strings.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ define({
2828
"PRODUCT_NAME": "Edge Web Fonts",
2929

3030
"DIALOG_DONE": "完了",
31+
"CANCEL": "キャンセル",
3132
"SEARCH_PLACEHOLDER": "検索",
3233
"BROWSE_FONTS_INSTRUCTIONS": "Web プロジェクトに追加する Web フォントを探して選択してください。",
3334
"CODEHINT_BROWSE": "Web Fonts を検索...",

nls/root/strings.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ define({
2828
"PRODUCT_NAME" : "Edge Web Fonts",
2929

3030
"DIALOG_DONE" : "Done",
31+
"CANCEL" : "Cancel",
3132
"SEARCH_PLACEHOLDER" : "Search",
3233
"BROWSE_FONTS_INSTRUCTIONS" : "Browse for and select the web font you wish to include in your web project.",
3334
"CODEHINT_BROWSE" : "Browse Web Fonts...", // Needs to be short to fit in popup, but not sure about acronym

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "edge-code-web-fonts",
33
"title": "Adobe Edge Web Fonts",
44
"description": "Adobe Edge Web Fonts gives you access to a free, high-quality web font library made possible by contributions from Adobe, Google, and designers around the world. The fonts are served by Typekit, so you can be sure of high performance and stability.",
5-
"version": "0.1.3",
5+
"version": "0.1.4",
66
"keywords": [".css", ".html"],
77
"homepage": "http://html.adobe.com/edge/webfonts/",
88
"bugs": "https://github.com/adobe/brackets-edge-web-fonts/issues",

styles/ewf-brackets.css

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,6 @@
2121
*
2222
*/
2323

24-
.edge-web-fonts-browse-dialog .modal-header .close,
25-
.edge-web-fonts-include-dialog .modal-header .close,
26-
.edge-web-fonts-howto-dialog .modal-header .close {
27-
margin-top: 0px;
28-
line-height: 40px;
29-
}
30-
3124
.edge-web-fonts-browse-dialog .modal-body {
3225
width: 520px;
3326
padding: 15px 0 15px 15px;

0 commit comments

Comments
 (0)