changes after review

Author: zaggino

src/extensibility/ExtensionManager.js

@@ -525,10 +525,10 @@ define(function (require, exports, module) {
 
     /**
      * Gets an array of extensions that are currently installed and can be updated to a new version
-     * @return {Array} array of objects with properies id,installVersion,registryVersion
-     *                 where id = extensionId
-     *                       installVersion = currently installed version of extension
-     *                       registryVersion = latest version compatible with current Brackets
+     * @return {Array.<{id: string, installVersion: string, registryVersion: string}>}
+     *     where id = extensionId
+     *     installVersion = currently installed version of extension
+     *     registryVersion = latest version compatible with current Brackets
      */
     function getAvailableUpdates() {
         var result = [];
@@ -550,12 +550,14 @@ define(function (require, exports, module) {
     }
 
     /**
-     * Takes array returned from getAvailableUpdates() as an input and removes those entries
+     * Takes the array returned from getAvailableUpdates() as an input and removes those entries
      * that are no longer current - when currently installed version of an extension
      * is equal or newer than registryVersion returned by getAvailableUpdates().
      * This function is designed to work without the necessity to download extension registry
-     * @param {Array} previous output of getAvailableUpdates()
-     * @param {Array} filtered input as function description
+     * @param {Array.<{id: string, installVersion: string, registryVersion: string}>} updates
+     *     previous output of getAvailableUpdates()
+     * @return {Array.<{id: string, installVersion: string, registryVersion: string}>}
+     *     filtered input as function description
      */
     function cleanAvailableUpdates(updates) {
         return updates.reduce(function (arr, updateInfo) {

src/extensibility/ExtensionManagerViewModel.js

@@ -424,8 +424,8 @@ define(function (require, exports, module) {
 
             var metadata1 = self.extensions[key1].installInfo.metadata,
                 metadata2 = self.extensions[key2].installInfo.metadata,
-                id1 = (metadata1.title || metadata1.name).toLowerCase(),
-                id2 = (metadata2.title || metadata2.name).toLowerCase();
+                id1 = (metadata1.title || metadata1.name).toLocaleLowerCase(),
+                id2 = (metadata2.title || metadata2.name).toLocaleLowerCase();
 
             return id1.localeCompare(id2);
         });

src/utils/UpdateNotification.js

@@ -42,8 +42,12 @@ define(function (require, exports, module) {
         UpdateDialogTemplate = require("text!htmlContent/update-dialog.html"),
         UpdateListTemplate   = require("text!htmlContent/update-list.html");
 
+    // duration of one day in milliseconds
     var ONE_DAY = 1000 * 60 * 60 * 24;
 
+    // duration of two minutes in milliseconds
+    var TWO_MINUTES = 1000 * 60 * 2;
+
     // Extract current build number from package.json version field 0.0.0-0
     var _buildNumber = Number(/-([0-9]+)/.exec(brackets.metadata.version)[1]);
 
@@ -250,11 +254,11 @@ define(function (require, exports, module) {
                 // downloadRegistry, will be resolved in _onRegistryDownloaded
                 ExtensionManager.downloadRegistry().done(function () {
                     // schedule another check in 24 hours + 2 minutes
-                    setTimeout(checkForExtensionsUpdate, ONE_DAY + (2 * 60 * 1000));
+                    setTimeout(checkForExtensionsUpdate, ONE_DAY + TWO_MINUTES);
                 });
             } else {
                 // schedule the download of the registry in appropriate time
-                setTimeout(checkForExtensionsUpdate, (timeOfNextCheck - currentTime) + (2 * 60 * 1000));
+                setTimeout(checkForExtensionsUpdate, (timeOfNextCheck - currentTime) + TWO_MINUTES);
             }
         }
     }
@@ -383,7 +387,7 @@ define(function (require, exports, module) {
         // launch immediately and then every 24 hours + 2 minutes
         checkForUpdate();
         checkForExtensionsUpdate();
-        window.setInterval(checkForUpdate, ONE_DAY + (2 * 60 * 1000));
+        window.setInterval(checkForUpdate, ONE_DAY + TWO_MINUTES);
     }
 
     // Append locale to version info URL