Fix WorkingSetView test based on review feedback.

Author: dangoor

test/spec/ProjectManager-test.js

@@ -23,7 +23,7 @@
 
 
 /*jslint vars: true, plusplus: true, devel: true, browser: true, nomen: true, indent: 4, maxerr: 50 */
-/*global $, define, describe, it, expect, afterEach, waitsFor, runs, waitsForDone, beforeFirst, afterLast */
+/*global $, define, describe, it, expect, afterEach, waitsFor, runs, waitsForDone, beforeFirst, afterLast, waitsForTime */
 
 define(function (require, exports, module) {
     "use strict";
@@ -373,13 +373,7 @@ define(function (require, exports, module) {
              * we'll need to wait for the next render.
              */
             function waitForRenderDebounce() {
-                runs(function () {
-                    var d = new $.Deferred();
-                    setTimeout(function () {
-                        d.resolve();
-                    }, ProjectManager._RENDER_DEBOUNCE_TIME);
-                    waitsForDone(d.promise());
-                });
+                waitsForTime(ProjectManager._RENDER_DEBOUNCE_TIME);
             }
 
             it("should deselect after opening file not rendered in tree", function () {

test/spec/SpecRunnerUtils.js

@@ -195,7 +195,23 @@ define(function (require, exports, module) {
             return promise.state() === "rejected";
         }, "failure " + operationName, timeout);
     };
-    
+
+    /**
+     * Utility for *rare* situations in which a test needs to pause for a *known* amount of time.
+     * Tests that sporadically fail due to timing issues can't really be fixed by this. This function
+     * was created when a debounce delay was added to updating the project tree, so we have a specific,
+     * known amount of time to pause for.
+     */
+    window.waitsForTime = function (timeout) {
+        runs(function () {
+            var d = new $.Deferred();
+            setTimeout(function () {
+                d.resolve();
+            }, timeout);
+            waitsForDone(d.promise());
+        });
+    };
+
     /**
      * Get or create a NativeFileSystem rooted at the system root.
      * @return {$.Promise} A promise resolved when the native file system is found or rejected when an error occurs.

test/spec/WorkingSetView-test.js

@@ -23,7 +23,7 @@
 
 
 /*jslint vars: true, plusplus: true, devel: true, browser: true, nomen: true, indent: 4, maxerr: 50 */
-/*global $, define, describe, it, xit, expect, beforeEach, afterEach, waitsFor, waitsForDone, runs, beforeFirst, afterLast */
+/*global $, define, describe, it, xit, expect, beforeEach, afterEach, waitsFor, waitsForDone, runs, beforeFirst, afterLast, waitsForTime */
 
 define(function (require, exports, module) {
     "use strict";
@@ -33,6 +33,7 @@ define(function (require, exports, module) {
         DocumentManager,        // Load from brackets.test
         FileViewController,     // Load from brackets.test
         MainViewManager,        // Load from brackets.test
+        ProjectManager,         // Load from brackets.test
         WorkingSetView,
         SpecRunnerUtils         = require("spec/SpecRunnerUtils");
 
@@ -74,6 +75,7 @@ define(function (require, exports, module) {
                 FileViewController  = testWindow.brackets.test.FileViewController;
                 MainViewManager     = testWindow.brackets.test.MainViewManager;
                 WorkingSetView      = testWindow.brackets.test.WorkingSetView;
+                ProjectManager      = testWindow.brackets.test.ProjectManager;
 
                 // Open a directory
                 if (loadProject) {
@@ -254,17 +256,22 @@ define(function (require, exports, module) {
         });
 
         it("should show the file in project tree when a file is being renamed", function () {
+            var $ = testWindow.$;
+            var secondItem =  $(".open-files-container > ul").children().eq(1);
+            var fileName = secondItem.text();
+
             runs(function () {
-                var $ = testWindow.$;
-                var secondItem =  $(".open-files-container > ul").children().eq(1);
-                var fileName = secondItem.text();
                 secondItem.trigger("click");
 
                 // Calling FILE_RENAME synchronously works fine here since the item is already visible in project file tree.
                 // However, if the selected item is not already visible in the tree, this command will complete asynchronously.
                 // In that case, waitsFor will be needed before continuing with the rest of the test.
                 CommandManager.execute(Commands.FILE_RENAME);
-                
+            });
+
+            waitsForTime(ProjectManager._RENDER_DEBOUNCE_TIME);
+
+            runs(function () {
                 expect($("#project-files-container ul input").val()).toBe(fileName);
             });
         });