Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Commit 6d9eb94

Browse files
author
Marcel Gerber
committed
Validate maxResults is an integer
1 parent d9bf2d7 commit 6d9eb94

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

src/editor/CodeHintList.js

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,13 @@ define(function (require, exports, module) {
2828
"use strict";
2929

3030
// Load dependent modules
31-
var Menus = require("command/Menus"),
31+
var KeyBindingManager = require("command/KeyBindingManager"),
32+
Menus = require("command/Menus"),
33+
KeyEvent = require("utils/KeyEvent"),
3234
StringUtils = require("utils/StringUtils"),
33-
PopUpManager = require("widgets/PopUpManager"),
35+
ValidationUtils = require("utils/ValidationUtils"),
3436
ViewUtils = require("utils/ViewUtils"),
35-
KeyBindingManager = require("command/KeyBindingManager"),
36-
KeyEvent = require("utils/KeyEvent");
37+
PopUpManager = require("widgets/PopUpManager");
3738

3839
var CodeHintListHTML = require("text!htmlContent/code-hint-list.html");
3940

@@ -64,7 +65,10 @@ define(function (require, exports, module) {
6465
*
6566
* @type {number}
6667
*/
67-
this.maxResults = Math.min((maxResults > 0 && maxResults) || 1000, 1000);
68+
this.maxResults = Math.min(
69+
(maxResults > 0 && ValidationUtils.isInteger(maxResults) && maxResults) || 1000,
70+
1000
71+
);
6872

6973
/**
7074
* Is the list currently open?

0 commit comments

Comments
 (0)