Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Commit 7192b13

Browse files
ficristoswmitra
authored andcommitted
Problems panel: add an icon per problem to tell which type it is (#13430)
1 parent 475dfc2 commit 7192b13

2 files changed

Lines changed: 28 additions & 1 deletion

File tree

src/htmlContent/problems-panel-table.html

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<tbody>
33
{{#reportList}}
44
<tr class="inspector-section">
5-
<td colspan="3">
5+
<td colspan="4">
66
<span class="disclosure-triangle {{#isExpanded}}expanded{{/isExpanded}}"></span>
77
<input type="hidden" value="{{providerName}}" />
88
{{providerName}} ({{results.length}})
@@ -11,6 +11,9 @@
1111
{{#results}}
1212
<tr class="{{display}}">
1313
<td class="line-number" data-character="{{pos.ch}}">{{friendlyLine}}</td>
14+
<td class="line-icon">
15+
<div class="line-icon-default line-icon-{{type}}"></div>
16+
</td>
1417
<td class="line-text">{{message}}</td>
1518
<td class="line-snippet">{{codeSnippet}}</td>
1619
</tr>

src/styles/brackets.less

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2112,9 +2112,33 @@ textarea.exclusions-editor {
21122112
text-align: right; // make line number line up with editor line numbers
21132113
}
21142114

2115+
.line-icon {
2116+
vertical-align: middle;
2117+
2118+
.line-icon-default {
2119+
width: 20px;
2120+
height: 18px;
2121+
background-image: url(images/topcoat-inactive-15.svg);
2122+
background-repeat: no-repeat;
2123+
background-position: 0px 1px;
2124+
}
2125+
2126+
// Add an image based on the type of the problem.
2127+
.line-icon-problem_type_error {
2128+
background-image: url(images/topcoat-error-15.svg);
2129+
}
2130+
.line-icon-problem_type_warning {
2131+
background-image: url(images/topcoat-warning-15.svg);
2132+
}
2133+
.line-icon-problem_type_meta {
2134+
background-image: url(images/topcoat-inactive-15.svg);
2135+
}
2136+
}
2137+
21152138
.line-text {
21162139
white-space: nowrap;
21172140
width: auto;
2141+
padding-left: 5px;
21182142
}
21192143

21202144
.line-snippet {

0 commit comments

Comments
 (0)