Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Commit 7b7670f

Browse files
committed
Size width of Quick Open dropdown more crisply.
Revert PR #7316 - no longer needed to fix #7307. Tweak the PR #7358 fix to cut down the delay before the dropdown appears to the bare minimum.
1 parent 72aa412 commit 7b7670f

3 files changed

Lines changed: 6 additions & 7 deletions

File tree

src/search/QuickSearchField.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ define(function (require, exports, module) {
242242
position: "absolute",
243243
top: this._dropdownTop,
244244
left: this.$input.offset().left,
245-
width: this.$input.width()
245+
width: this.$input.outerWidth()
246246
})
247247
.click(function (event) {
248248
// Unlike the Enter key, where we wait to catch up with typing, clicking commits immediately

src/styles/brackets.less

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1292,16 +1292,15 @@ textarea.exclusions-editor {
12921292
}
12931293

12941294
.quick-search-container {
1295-
// the borders show up even if the container is empty, must set height to zero using JS.
1295+
border: 1px solid @tc-gray-panel-border;
1296+
box-sizing: border-box; // lets QuickSearchField size the width more nicely
12961297
background-color: @tc-gray-panel;
12971298
border-radius: 0 0 4px 4px;
12981299
box-shadow: @tc-normal-shadow-bottom;
12991300
opacity: 0;
13001301

1301-
// Need this for border-radius because there are no borders
1302-
overflow: hidden;
1303-
1304-
.animation (autocomplete, 90ms, cubic-bezier(.01, .91, 0, .99), 190ms, 1);
1302+
// Animation delayed to avoid overlapping with modal-bar slide in, which would make it stuttery
1303+
.animation (autocomplete, 90ms, cubic-bezier(.01, .91, 0, .99), 66ms, 1);
13051304
-webkit-animation-fill-mode: forwards;
13061305
animation-fill-mode: forwards;
13071306
-webkit-transform-origin: 0 0;

src/styles/brackets_colors.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@
9898
@tc-panel-border-radius: 5px;
9999
@tc-small-shadow-top: 0 -1px 3px rgba(0, 0, 0, 0.12);
100100
@tc-small-shadow-bottom: 0 1px 3px rgba(0, 0, 0, 0.12);
101-
@tc-normal-shadow-bottom: 0 5px 10px rgba(0, 0, 0, 0.21);
101+
@tc-normal-shadow-bottom: 0 5px 10px rgba(0, 0, 0, 0.1);
102102
@tc-highlight: #e0f0fa;
103103
@tc-selected-row: #d0d5d5;
104104
@tc-hover-highlight: rgba(255, 255, 255, 0.6);

0 commit comments

Comments
 (0)