Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Commit 7c84940

Browse files
committed
Fix Extension Manager bug: a poorly-scoped jQuery call causes it to see
*all* Bootstrap tabs in the entire DOM as part of its tab set, so it will crash if any such other tabs exist in the UI. This was the only jQuery call in the Extension Manager code that wasn't scoped down to $dlg (or used an equivalent parent selector).
1 parent 12e3e6a commit 7c84940

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/extensibility/ExtensionManagerDialog.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ define(function (require, exports, module) {
255255
});
256256

257257
// Update search UI before new tab is shown
258-
$("a[data-toggle='tab']").each(function (index, tabElement) {
258+
$("a[data-toggle='tab']", $dlg).each(function (index, tabElement) {
259259
$(tabElement).on("show", function (event) {
260260
_activeTabIndex = index;
261261

0 commit comments

Comments
 (0)