Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Commit 801aafc

Browse files
author
Narciso Jaramillo
committed
Merge pull request #3042 from adobe/jrb/static-server-cleanup
StaticServerDomain - remove module variable holding on to domainManager for no reason
2 parents ab51421 + 490d6f4 commit 801aafc

1 file changed

Lines changed: 6 additions & 14 deletions

File tree

src/extensions/default/StaticServer/node/StaticServerDomain.js

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,6 @@ maxerr: 50, node: true */
5252
*/
5353
var _servers = {};
5454

55-
/**
56-
* @private
57-
* @type {DomainManager}
58-
* The DomainManager passed in at init.
59-
*/
60-
var _domainManager = null;
61-
6255
/**
6356
* @private
6457
* Helper function to create a new server.
@@ -164,14 +157,13 @@ maxerr: 50, node: true */
164157

165158
/**
166159
* Initializes the StaticServer domain with its commands.
167-
* @param {DomainManager} DomainManager The DomainManager for the server
160+
* @param {DomainManager} domainManager The DomainManager for the server
168161
*/
169-
function init(DomainManager) {
170-
_domainManager = DomainManager;
171-
if (!_domainManager.hasDomain("staticServer")) {
172-
_domainManager.registerDomain("staticServer", {major: 0, minor: 1});
162+
function init(domainManager) {
163+
if (!domainManager.hasDomain("staticServer")) {
164+
domainManager.registerDomain("staticServer", {major: 0, minor: 1});
173165
}
174-
_domainManager.registerCommand(
166+
domainManager.registerCommand(
175167
"staticServer",
176168
"getServer",
177169
_cmdGetServer,
@@ -188,7 +180,7 @@ maxerr: 50, node: true */
188180
description: "hostname (stored in 'address' parameter), port, and socket type (stored in 'family' parameter) for the server. Currently, 'family' will always be 'IPv4'."
189181
}]
190182
);
191-
_domainManager.registerCommand(
183+
domainManager.registerCommand(
192184
"staticServer",
193185
"closeServer",
194186
_cmdCloseServer,

0 commit comments

Comments
 (0)