Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Commit 8bd7adb

Browse files
committed
Addressed comments
Signed-off-by: Pete Nykanen <pete.a.nykanen@gmail.com>
1 parent 5d0f0e9 commit 8bd7adb

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

src/editor/CodeHintList.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -326,9 +326,9 @@ define(function (require, exports, module) {
326326
* Convert keydown events into hint list navigation actions.
327327
*
328328
* @param {KeyBoardEvent} keyEvent
329-
* @param {bool} isFakeCallUp - True if faked call up (for example calling CTRL+Space while hints are open)
329+
* @param {bool} isFakeKeydown - True if faked key down call (for example calling CTRL+Space while hints are open)
330330
*/
331-
CodeHintList.prototype._keydownHook = function (event, isFakeCallUp) {
331+
CodeHintList.prototype._keydownHook = function (event, isFakeKeydown) {
332332
var keyCode,
333333
self = this;
334334

@@ -390,13 +390,13 @@ define(function (require, exports, module) {
390390
}
391391

392392
// (page) up, (page) down, enter and tab key are handled by the list
393-
if (event.type === "keydown" && this.isHandlingKeyCode(event) || isFakeCallUp) {
393+
if ((event.type === "keydown" || isFakeKeydown) && this.isHandlingKeyCode(event)) {
394394
keyCode = event.keyCode;
395395

396396
if (event.keyCode === KeyEvent.DOM_VK_ESCAPE) {
397397
event.stopImmediatePropagation();
398398
this.handleClose();
399-
399+
400400
return false;
401401
} else if (event.shiftKey &&
402402
(event.keyCode === KeyEvent.DOM_VK_UP ||
@@ -409,7 +409,7 @@ define(function (require, exports, module) {
409409
} else if (keyCode === KeyEvent.DOM_VK_UP) {
410410
_rotateSelection.call(this, -1);
411411
} else if (keyCode === KeyEvent.DOM_VK_DOWN ||
412-
(event.ctrlKey && keyCode === KeyEvent.DOM_VK_SPACE) || isFakeCallUp) {
412+
(event.ctrlKey && keyCode === KeyEvent.DOM_VK_SPACE)) {
413413
_rotateSelection.call(this, 1);
414414
} else if (keyCode === KeyEvent.DOM_VK_PAGE_UP) {
415415
_rotateSelection.call(this, -_itemsPerPage());

0 commit comments

Comments
 (0)