Fix #5310 (Editor HTML menus are broken).

busykai · busykai · commit 8e5ad9573335 · 2013-09-23T19:41:53.000-03:00
Override the implementation of the jquery focus() to prevent HTML menus
(class "dropdown-toggle") grabbing the focus.

Bootstrap's dropdown implementation exlicitly calls focus() which causes
currently active CM instance to lose focus. As the result, when the
command is executed, it cannot get ahold of the current editor instance.
diff --git a/src/brackets.js b/src/brackets.js
@@ -273,6 +273,16 @@ define(function (require, exports, module) {
         // Enable/Disable HTML Menus
         if (brackets.nativeMenus) {
             $("body").addClass("has-appshell-menus");
+        } else {
+            // Prevent the menu item to grab the focus -- override focus implementation
+            (function () {
+                var defaultFocus = $.fn.focus;
+                $.fn.focus = function () {
+                    if (!this.hasClass("dropdown-toggle")) {
+                        defaultFocus.apply(this, arguments);
+                    }
+                };
+            }());
         }
         
         // Localize MainViewHTML and inject into <BODY> tag
