Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Commit 8fbbeed

Browse files
committed
Change how QuickEdit helper function is passed from CodeHints to QuickEdit:
It now gets set directly as brackets._jsCodeHintsHelper = quickEditHelpe;. as suggested.
1 parent 2bcdc3a commit 8fbbeed

3 files changed

Lines changed: 2 additions & 26 deletions

File tree

src/editor/EditorManager.js

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -94,12 +94,6 @@ define(function (require, exports, module) {
9494
*/
9595
var _inlineEditProviders = [];
9696

97-
/**
98-
* QuickEdit helper function.
99-
* @type {function}
100-
*/
101-
var _quickEditHelper = null;
102-
10397
/**
10498
* Registered inline documentation widget providers. See {@link #registerInlineDocsProvider()}.
10599
* @type {Array.<function(...)>}
@@ -221,22 +215,6 @@ define(function (require, exports, module) {
221215
_inlineEditProviders.push(provider);
222216
}
223217

224-
/**
225-
* Registers a helper for QuickEdit to provide a hook into Tern's jump-to-defintion.
226-
*
227-
* @param {function}
228-
*/
229-
function registerQuickEditHelper(helper) {
230-
_quickEditHelper = helper;
231-
}
232-
233-
/**
234-
* Return QuickEdit helper.
235-
*/
236-
function getQuickEditHelper() {
237-
return _quickEditHelper;
238-
}
239-
240218
/**
241219
* Registers a new inline docs provider. When Quick Docs is invoked each registered provider is
242220
* asked if it wants to provide inline docs given the current editor and cursor location.
@@ -754,8 +732,6 @@ define(function (require, exports, module) {
754732
exports.getFocusedInlineWidget = getFocusedInlineWidget;
755733
exports.resizeEditor = resizeEditor;
756734
exports.registerInlineEditProvider = registerInlineEditProvider;
757-
exports.registerQuickEditHelper = registerQuickEditHelper;
758-
exports.getQuickEditHelper = getQuickEditHelper;
759735
exports.registerInlineDocsProvider = registerInlineDocsProvider;
760736
exports.getInlineEditors = getInlineEditors;
761737
exports.closeInlineWidget = closeInlineWidget;

src/extensions/default/JavaScriptCodeHints/main.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,7 @@ define(function (require, exports, module) {
587587
CommandManager.register(Strings.CMD_JUMPTO_DEFINITION, JUMPTO_DEFINITION, handleJumpToDefinition);
588588

589589
// Register quickEditHelper.
590-
EditorManager.registerQuickEditHelper(quickEditHelper);
590+
brackets._jsCodeHintsHelper = quickEditHelper;
591591

592592
// Add the menu item
593593
var menu = Menus.getMenu(Menus.AppMenuBar.NAVIGATE_MENU);

src/extensions/default/JavaScriptQuickEdit/main.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ define(function (require, exports, module) {
105105
*/
106106
function _createInlineEditor(hostEditor, functionName) {
107107
// Use Tern jump-to-definition helper, if it's available, to find InlineEditor target.
108-
var helper = EditorManager.getQuickEditHelper();
108+
var helper = brackets._jsCodeHintsHelper;
109109
if (helper === null) {
110110
return null;
111111
}

0 commit comments

Comments
 (0)