rework per discovery and cleanup

Author: JeffryBooher

src/filesystem/FileSystem.js

@@ -92,6 +92,7 @@ define(function (require, exports, module) {
     var Directory       = require("filesystem/Directory"),
         File            = require("filesystem/File"),
         FileIndex       = require("filesystem/FileIndex"),
+        FileSystemError = require("filesystem/FileSystemError"),
         WatchedRoot     = require("filesystem/WatchedRoot");
 
     /**
@@ -886,7 +887,7 @@ define(function (require, exports, module) {
         callback = callback || function () {};
 
         if (!watchedRoot) {
-            callback("Root is not watched.");
+            callback(FileSystemError.ROOT_NOT_WATCHED);
             return;
         }
 

src/filesystem/FileSystemError.js

@@ -44,7 +44,8 @@ define(function (require, exports, module) {
         TOO_MANY_ENTRIES            : "TooManyEntries",
         ALREADY_EXISTS              : "AlreadyExists",
         CONTENTS_MODIFIED           : "ContentsModified",
-        PATH_WATCHING_NOT_SUPPORTED : "PathWatchingNotSupported"
+        PATH_WATCHING_NOT_SUPPORTED : "PathWatchingNotSupported",
+        ROOT_NOT_WATCHED            : "RootNotBeingWatched"
 
         // FUTURE: Add remote connection errors: timeout, not logged in, connection err, etc.
     };

src/filesystem/impls/appshell/AppshellFileSystem.js

@@ -578,8 +578,7 @@ define(function (require, exports, module) {
      *
      * @type {boolean}
      */
-    exports.recursiveWatch = (appshell.platform === "mac" ||
-        (appshell.platform === "win" && navigator.userAgent.indexOf("Windows NT 5.") === -1));
+    exports.recursiveWatch = (appshell.platform === "mac" || appshell.platform === "win");
 
     /**
      * Indicates whether or not the filesystem should expect and normalize UNC