Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Commit b87b196

Browse files
Merge pull request #12035 from petetnt/petetnt/update-react
Update React to 0.14.7 and Immutable to 3.7.6.
2 parents 8e49f35 + 71d1442 commit b87b196

7 files changed

Lines changed: 9821 additions & 10523 deletions

File tree

src/main.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,16 @@ require.config({
3232
paths: {
3333
"text" : "thirdparty/text/text",
3434
"i18n" : "thirdparty/i18n/i18n",
35+
"react" : "thirdparty/react",
3536

3637
// The file system implementation. Change this value to use different
3738
// implementations (e.g. cloud-based storage).
3839
"fileSystemImpl" : "filesystem/impls/appshell/AppshellFileSystem"
3940
},
4041
map: {
4142
"*": {
42-
"thirdparty/CodeMirror2": "thirdparty/CodeMirror"
43+
"thirdparty/CodeMirror2": "thirdparty/CodeMirror",
44+
"thirdparty/react": "react"
4345
}
4446
}
4547
});

src/project/FileTreeView.js

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ define(function (require, exports, module) {
3333
"use strict";
3434

3535
var React = require("thirdparty/react"),
36+
ReactDOM = require("thirdparty/react-dom"),
3637
Classnames = require("thirdparty/classnames"),
3738
Immutable = require("thirdparty/immutable"),
3839
_ = require("thirdparty/lodash"),
@@ -141,14 +142,14 @@ define(function (require, exports, module) {
141142
* this component, so we keep the model up to date by sending every update via an action.
142143
*/
143144
handleInput: function (e) {
144-
this.props.actions.setRenameValue(this.refs.name.getDOMNode().value.trim());
145+
this.props.actions.setRenameValue(this.refs.name.value.trim());
145146

146147
if (e.keyCode !== KeyEvent.DOM_VK_LEFT &&
147148
e.keyCode !== KeyEvent.DOM_VK_RIGHT) {
148149
// update the width of the input field
149-
var domNode = this.refs.name.getDOMNode(),
150-
newWidth = _measureText(domNode.value);
151-
$(domNode).width(newWidth);
150+
var node = this.refs.name,
151+
newWidth = _measureText(node.value);
152+
$(node).width(newWidth);
152153
}
153154
},
154155

@@ -181,7 +182,7 @@ define(function (require, exports, module) {
181182
var fullname = this.props.name,
182183
extension = LanguageManager.getCompoundFileExtension(fullname);
183184

184-
var node = this.refs.name.getDOMNode();
185+
var node = this.refs.name;
185186
node.setSelectionRange(0, _getName(fullname, extension).length);
186187
ViewUtils.scrollElementIntoView($("#project-files-container"), $(node), true);
187188
},
@@ -362,7 +363,7 @@ define(function (require, exports, module) {
362363
// start with project-files-container instead of just the interior of
363364
// project-files-container and then the file tree will be one self-contained
364365
// functional unit.
365-
ViewUtils.scrollElementIntoView($("#project-files-container"), $(this.getDOMNode()), true);
366+
ViewUtils.scrollElementIntoView($("#project-files-container"), $(ReactDOM.findDOMNode(this)), true);
366367
} else if (!isSelected && wasSelected && this.state.clickTimer !== null) {
367368
this.clearTimer();
368369
}
@@ -554,7 +555,7 @@ define(function (require, exports, module) {
554555
componentDidMount: function () {
555556
var fullname = this.props.name;
556557

557-
var node = this.refs.name.getDOMNode();
558+
var node = this.refs.name;
558559
node.setSelectionRange(0, fullname.length);
559560
ViewUtils.scrollElementIntoView($("#project-files-container"), $(node), true);
560561
},
@@ -810,7 +811,7 @@ define(function (require, exports, module) {
810811
return;
811812
}
812813

813-
var node = this.getDOMNode(),
814+
var node = ReactDOM.findDOMNode(this),
814815
selectedNode = $(node.parentNode).find(this.props.selectedClassName),
815816
selectionViewInfo = this.props.selectionViewInfo;
816817

@@ -865,7 +866,7 @@ define(function (require, exports, module) {
865866
return;
866867
}
867868

868-
var node = this.getDOMNode(),
869+
var node = ReactDOM.findDOMNode(this),
869870
selectedNode = $(node.parentNode).find(this.props.selectedClassName),
870871
selectionViewInfo = this.props.selectionViewInfo;
871872

@@ -1012,7 +1013,7 @@ define(function (require, exports, module) {
10121013
return;
10131014
}
10141015

1015-
React.render(fileTreeView({
1016+
ReactDOM.render(fileTreeView({
10161017
treeData: viewModel.treeData,
10171018
selectionViewInfo: viewModel.selectionViewInfo,
10181019
sortDirectoriesFirst: viewModel.sortDirectoriesFirst,

0 commit comments

Comments
 (0)