Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Commit c118a97

Browse files
committed
Tweaks to status bar language-picker's appearance:
- Fix bug in DropdownButton that led to it often being positioned too far to the left - CSS to join more cleanly with top border of status bar (not perfect, though: the dropshadow & animation both still feel a little odd)
1 parent dce3176 commit c118a97

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

src/styles/brackets_patterns_override.less

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -526,6 +526,11 @@ a:focus {
526526
height: auto;
527527
max-height: 80%;
528528

529+
// Improve how bottom of the dropdown joins with top of status bar button
530+
margin-top: -6px;
531+
border-bottom-left-radius: 0;
532+
border-bottom-right-radius: 0;
533+
529534
li a .default-language {
530535
font-style: italic;
531536
color: @tc-quiet-text;

src/widgets/DropdownButton.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,8 @@ define(function (require, exports, module) {
228228
Menus.closeAll();
229229

230230
var $dropdown = $("<ul class='dropdown-menu dropdownbutton-popup' tabindex='-1'>")
231-
.addClass(this.dropdownExtraClasses); // (no-op if unspecified)
231+
.addClass(this.dropdownExtraClasses) // (no-op if unspecified)
232+
.css("min-width", this.$button.outerWidth()); // do this before the clipping calcs below
232233

233234
this.$dropdown = $dropdown;
234235
this._renderList(this.$dropdown)
@@ -259,8 +260,7 @@ define(function (require, exports, module) {
259260

260261
$dropdown.css({
261262
left: posLeft,
262-
top: posTop,
263-
minWidth: this.$button.outerWidth()
263+
top: posTop
264264
});
265265

266266
// Attach event handlers

0 commit comments

Comments
 (0)