Code review: add docs; tweak color per Larz; test

ExtensionManagerViewModel.notifyCount in a few unit tests

Author: peterflynn

src/extensibility/ExtensionManagerDialog.js

@@ -191,6 +191,7 @@ define(function (require, exports, module) {
                 $(this).tab("show");
             });
 
+        // Update & hide/show the notification overlay on a tab's icon, based on its model's notifyCount
         function updateNotificationIcon(index) {
             var model = models[index],
                 $notificationIcon = $dlg.find(".nav-tabs li").eq(index).find(".notification");

src/extensibility/ExtensionManagerViewModel.js

@@ -407,6 +407,10 @@ define(function (require, exports, module) {
         });
     };
 
+    /**
+     * @private
+     * Updates notifyCount based on number of extensions with an update available
+     */
     InstalledViewModel.prototype._countUpdates = function () {
         var self = this;
         this.notifyCount = 0;

src/styles/brackets_patterns_override.less

@@ -732,7 +732,7 @@ a[href^="http"] {
                 position: relative;  // for positioning .notification icon
                 > .notification {
                     display: none;  // hidden by default
-                    background-color: #A83F3F;
+                    background-color: #91CC41;
                     color: white;
                     border-radius: 16px;
                     padding: 0 5px;

test/spec/ExtensionManager-test.js

@@ -1040,11 +1040,18 @@ define(function (require, exports, module) {
                                     item.metadata.name === "mock-legacy-extension") {
                                 expect(view).toHaveText(item.metadata.name);
                                 expect($button.length).toBe(1);
+                                
+                                // But no update button
+                                var $updateButton = $("button.update[data-extension-id=" + item.metadata.name + "]", view.$el);
+                                expect($updateButton.length).toBe(0);
                             } else {
                                 expect(view).not.toHaveText(item.metadata.name);
                                 expect($button.length).toBe(0);
                             }
                         });
+                        
+                        // And no overall update icon overlay
+                        expect(model.notifyCount).toBe(0);
                     });
                 });
 
@@ -1172,6 +1179,7 @@ define(function (require, exports, module) {
                         var $button = $("button.update[data-extension-id=mock-extension]", view.$el);
                         expect($button.length).toBe(1);
                         expect($button.prop("disabled")).toBeFalsy();
+                        expect(model.notifyCount).toBe(1);
 
                         expect($("button.install[data-extension-id=mock-extension]", view.$el).length).toBe(0);
                     });
@@ -1189,6 +1197,7 @@ define(function (require, exports, module) {
                         var $button = $("button.update[data-extension-id=mock-extension]", view.$el);
                         expect($button.length).toBe(1);
                         expect($button.prop("disabled")).toBeTruthy();
+                        expect(model.notifyCount).toBe(1);
 
                         expect($("button.install[data-extension-id=mock-extension]", view.$el).length).toBe(0);
                         expect($(".alert.warning", view.$el).length).toBe(0);
@@ -1206,6 +1215,7 @@ define(function (require, exports, module) {
                         var $button = $("button.update[data-extension-id=mock-extension]", view.$el);
                         expect($button.length).toBe(1);
                         expect($button.prop("disabled")).toBeTruthy();
+                        expect(model.notifyCount).toBe(1);
 
                         expect($("button.install[data-extension-id=mock-extension]", view.$el).length).toBe(0);
                         expect($(".alert.warning", view.$el).length).toBe(0);