Fix: Adding tooltip to JSLint star on start-up with JSLint disabled#2280
Fix: Adding tooltip to JSLint star on start-up with JSLint disabled#2280peterflynn merged 2 commits intoadobe:masterfrom TomMalbran:tom/fix-issue-2270
Conversation
|
@TomMalbran: But actually, it looks like the initial _setEnabled() call from _prefs will always force a run() already. I think the problem is, because it happens before htmlReady, the UI isn't there to be updated yet. Do you want to try moving the _setEnabled() call into the htmlReady callback and see if that fixes it? (And do some testing to make sure it doesn't have any negative side effects). If that works I think it's the cleanest fix. We should add a comment onto the _setEnabled() call saying it triggers the initial UI update, and then that's that. |
|
That did fixed this and the previews JSLint bug. I did several testing and it seem to be working fine in all the cases. |
|
Thanks, looks nice & clean. Seems to work find on my end too. Merging. |
Fix: Adding tooltip to JSLint star on start-up with JSLint disabled
This is a fix for #2270 and follow-up pull request of #2100