Skip to content

Commit 33a6daf

Browse files
authored
Merge pull request #418 from adopted-ember-addons/revert-415-inject-from-service-deprecated
Revert "import service instead of inject from '@ember/service'"
2 parents e2514a4 + f9e6f18 commit 33a6daf

11 files changed

Lines changed: 11 additions & 31 deletions

File tree

ember-moment/src/helpers/-base.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
import { run } from '@ember/runloop';
22
import Helper from '@ember/component/helper';
33
import { observer } from '@ember/object';
4-
import * as emberService from '@ember/service';
5-
6-
const service = emberService.service ?? emberService.inject;
4+
import { inject as service } from '@ember/service';
75

86
// eslint-disable-next-line ember/no-classic-classes
97
export default Helper.extend({

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"release-plan": "^0.9.0"
2323
},
2424
"volta": {
25-
"node": "18.20.3",
25+
"node": "24.14.1",
2626
"pnpm": "9.4.0"
2727
},
2828
"pnpm": {

test-app-3.x/app/controllers/index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
import { action, set } from '@ember/object';
22
import { dependentKeyCompat } from '@ember/object/compat';
33
import { tracked } from '@glimmer/tracking';
4+
import { inject as service } from '@ember/service';
45
import Controller from '@ember/controller';
5-
import * as emberService from '@ember/service';
6-
7-
const service = emberService.service ?? emberService.inject;
86

97
export default class Index extends Controller {
108
@service moment;

test-app-3.x/app/routes/application.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
import Route from '@ember/routing/route';
2-
import * as emberService from '@ember/service';
3-
4-
const service = emberService.service ?? emberService.inject;
2+
import { inject as service } from '@ember/service';
53

64
export default class Application extends Route {
75
@service moment;

test-app-3.x/app/routes/index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
import Route from '@ember/routing/route';
2+
import { inject as service } from '@ember/service';
23
import { set } from '@ember/object';
34
import { run } from '@ember/runloop';
4-
import * as emberService from '@ember/service';
5-
6-
const service = emberService.service ?? emberService.inject;
75

86
export default class Index extends Route {
97
@service moment;

test-app-4.x/app/controllers/index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
import { action, set } from '@ember/object';
22
import { dependentKeyCompat } from '@ember/object/compat';
33
import { tracked } from '@glimmer/tracking';
4+
import { inject as service } from '@ember/service';
45
import Controller from '@ember/controller';
5-
import * as emberService from '@ember/service';
6-
7-
const service = emberService.service ?? emberService.inject;
86

97
export default class Index extends Controller {
108
@service moment;

test-app-4.x/app/routes/application.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
import Route from '@ember/routing/route';
2-
import * as emberService from '@ember/service';
3-
4-
const service = emberService.service ?? emberService.inject;
2+
import { inject as service } from '@ember/service';
53

64
export default class Application extends Route {
75
@service moment;

test-app-4.x/app/routes/index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
import Route from '@ember/routing/route';
2+
import { inject as service } from '@ember/service';
23
import { set } from '@ember/object';
34
import { run } from '@ember/runloop';
4-
import * as emberService from '@ember/service';
5-
6-
const service = emberService.service ?? emberService.inject;
75

86
export default class Index extends Route {
97
@service moment;

test-app-5.x/app/controllers/index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
import { action, set } from '@ember/object';
22
import { dependentKeyCompat } from '@ember/object/compat';
33
import { tracked } from '@glimmer/tracking';
4+
import { inject as service } from '@ember/service';
45
import Controller from '@ember/controller';
5-
import * as emberService from '@ember/service';
6-
7-
const service = emberService.service ?? emberService.inject;
86

97
export default class Index extends Controller {
108
@service moment;

test-app-5.x/app/routes/application.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
import Route from '@ember/routing/route';
2-
import * as emberService from '@ember/service';
3-
4-
const service = emberService.service ?? emberService.inject;
2+
import { inject as service } from '@ember/service';
53

64
export default class Application extends Route {
75
@service moment;

0 commit comments

Comments
 (0)