CI/test fixes: update tests, lints, and small refactors

Author: Adwait Deshpande

Cargo.lock

@@ -4,7 +4,7 @@ use humansize::{format_size, DECIMAL};
 use ignore::WalkBuilder;
 use std::collections::HashMap;
 use std::fs;
-use std::path::PathBuf;
+use std::path::{Path, PathBuf};
 
 pub fn run_report(path: Option<PathBuf>, recipes_path: Option<PathBuf>, output: Option<PathBuf>) -> Result<()> {
 	let root = path.unwrap_or(std::env::current_dir()?);
@@ -13,7 +13,7 @@ pub fn run_report(path: Option<PathBuf>, recipes_path: Option<PathBuf>, output:
 	let out = output.unwrap_or_else(|| PathBuf::from("report.md"));
 
 	let mut lines: Vec<String> = Vec::new();
-	lines.push(format!("# DevSpace Sweeper Report"));
+	lines.push("# DevSpace Sweeper Report".to_string());
 	lines.push(format!("Root: {}\n", root.display()));
 	let mut total = 0u64;
 
@@ -34,7 +34,8 @@ pub fn run_report(path: Option<PathBuf>, recipes_path: Option<PathBuf>, output:
 	Ok(())
 }
 
-pub fn compute_ignore_hints(root: &PathBuf, patterns: &[&str]) -> HashMap<String, usize> {
+#[allow(dead_code)]
+pub fn compute_ignore_hints(_root: &Path, patterns: &[&str]) -> HashMap<String, usize> {
 	let mut hints: HashMap<String, usize> = HashMap::new();
 	for p in patterns {
 		*hints.entry((*p).to_string()).or_insert(0) += 1;

src/report.rs

@@ -7,6 +7,7 @@ use std::fs;
 use std::io::Write;
 use std::path::{Path, PathBuf};
 
+#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub struct MatchInfo {
 	pub path: PathBuf,
@@ -96,7 +97,8 @@ pub fn run_gen_ignore(path: Option<PathBuf>, recipes_path: Option<PathBuf>, dry_
 		fs::OpenOptions::new().append(true).open(&gi_path)
 			.with_context(|| format!("Failed to open {}", gi_path.display()))?
 	} else {
-		fs::OpenOptions::new().create(true).write(true).open(&gi_path)
+		// Explicitly set truncate(false) so behavior is clear to clippy/lints
+		fs::OpenOptions::new().create(true).write(true).truncate(false).open(&gi_path)
 			.with_context(|| format!("Failed to create {}", gi_path.display()))?
 	};
 	writeln!(file, "\n# Added by devspace-sweeper")?;

src/scan.rs

@@ -1,4 +1,5 @@
 use assert_cmd::Command;
+use assert_cmd::cargo::cargo_bin_cmd;
 use predicates::prelude::*;
 use std::fs;
 use std::path::PathBuf;
@@ -20,7 +21,7 @@ fn create_fixture() -> (TempDir, PathBuf) {
 #[test]
 fn scan_should_list_groups() {
 	let (_td, root) = create_fixture();
-	let mut cmd = Command::cargo_bin("devspace-sweeper").unwrap();
+	let mut cmd = cargo_bin_cmd!("devspace-sweeper");
 	cmd.arg("scan").arg("--path").arg(root);
 	cmd.assert()
 		.success()
@@ -32,7 +33,7 @@ fn scan_should_list_groups() {
 #[test]
 fn suggest_should_print_hints_and_safety() {
 	let (_td, root) = create_fixture();
-	let mut cmd = Command::cargo_bin("devspace-sweeper").unwrap();
+	let mut cmd = cargo_bin_cmd!("devspace-sweeper");
 	cmd.arg("suggest").arg("--path").arg(root);
 	cmd.assert()
 		.success()
@@ -43,7 +44,7 @@ fn suggest_should_print_hints_and_safety() {
 #[test]
 fn gen_ignore_dry_run_should_output_patterns() {
 	let (_td, root) = create_fixture();
-	let mut cmd = Command::cargo_bin("devspace-sweeper").unwrap();
+	let mut cmd = cargo_bin_cmd!("devspace-sweeper");
 	cmd.arg("gen-ignore").arg("--path").arg(&root).arg("--dry-run").arg("true");
 	cmd.assert()
 		.success()