Skip to content

Commit 0528097

Browse files
committed
Fix test_refresh_preserves_state not waiting for collapse
history_panel_click_item_title was called with wait=False when collapsing dataset details. This returned immediately after clicking, without waiting for the GCollapse animation to complete or the ExpandedItems store to persist the collapsed state to sessionStorage. The subsequent navigation (self.home()) could then race ahead of the state persistence, causing the item to appear expanded after refresh. Fix: use wait=True so the click waits for details_component.wait_for_absent_or_hidden(), matching the pattern already used for expanding in the same test.
1 parent e86b306 commit 0528097

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

lib/galaxy_test/selenium/test_history_panel.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,6 @@ def clear_tags(self, expected_tags_size):
156156
close_btn.click()
157157
self.sleep_for(self.wait_types.UX_RENDER)
158158

159-
@selenium_only("Not yet migrated to support Playwright backend")
160159
@selenium_test
161160
def test_refresh_preserves_state(self):
162161
self.perform_upload(self.get_filename("1.txt"))
@@ -175,7 +174,7 @@ def test_refresh_preserves_state(self):
175174
assert self.history_panel_item_showing_details(hid=1)
176175

177176
# Close the detailed display, refresh, and ensure they are still closed.
178-
self.history_panel_click_item_title(hid=1, wait=False)
177+
self.history_panel_click_item_title(hid=1, wait=True)
179178
assert not self.history_panel_item_showing_details(hid=1)
180179

181180
self._refresh()

0 commit comments

Comments
 (0)