Skip to content

Commit 35dcde7

Browse files
committed
Pin rocrate<0.15.0 until roc-validator supports RO-Crate Metadata Specification 1.2
rocrate 0.15.0 produces crates conforming to 1.2 spec by default, which causes roc-validator validation errors like: ``` The RO-Crate metadata file descriptor MUST have a `conformsTo` property with the RO-Crate specification version ``` xref crs4/rocrate-validator#107 Also: - Remove unused `BaseWorkflowPopulator.validate_invocation_crate_directory()` method.
1 parent f16c986 commit 35dcde7

3 files changed

Lines changed: 2 additions & 9 deletions

File tree

lib/galaxy_test/base/populators.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2551,13 +2551,6 @@ def get_ro_crate(self, invocation_id, include_files=False):
25512551
)
25522552
return ROCrate(crate_response)
25532553

2554-
def validate_invocation_crate_directory(self, crate_directory):
2555-
# TODO: where can a ro_crate be extracted
2556-
metadata_json_path = crate_directory / "ro-crate-metadata.json"
2557-
with metadata_json_path.open() as f:
2558-
metadata_json = json.load(f)
2559-
assert metadata_json["@context"] == "https://w3id.org/ro/crate/1.1/context"
2560-
25612554
def invoke_workflow_raw(self, workflow_id: str, request: dict, assert_ok: bool = False) -> Response:
25622555
url = f"workflows/{workflow_id}/invocations"
25632556
invocation_response = self._post(url, data=request, json=True)

packages/data/setup.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ install_requires =
5959
pypng
6060
python-magic
6161
pysam>=0.21
62-
rocrate
62+
rocrate<0.15.0
6363
social-auth-core>=4.5.0
6464
SQLAlchemy>=2.0.37,<2.1,!=2.0.41
6565
tifffile

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ dependencies = [
9191
"refgenconf>=0.13.0", # https://github.com/refgenie/refgenconf/pull/149
9292
"regex",
9393
"requests",
94-
"rocrate",
94+
"rocrate<0.15.0", # https://github.com/crs4/rocrate-validator/issues/107
9595
"Routes",
9696
"s3fs>=2023.1.0",
9797
"schema-salad>=8.7.20240905150001", # Python 3.13 support

0 commit comments

Comments
 (0)