Skip to content

Commit 3609832

Browse files
committed
Attempt to fix transiently failing tests that click this tab.
``` =================================== FAILURES =================================== _________ TestDataset.test_history_dataset_update_annotation_and_info __________ self = <galaxy_test.selenium.test_dataset.TestDataset object at 0x7f9ab6852e50> @selenium_test @managed_history def test_history_dataset_update_annotation_and_info(self): history_entry = self.perform_single_upload(self.get_filename("1.txt")) hid = history_entry.hid self.wait_for_history() self.history_panel_wait_for_hid_ok(hid) self.history_panel_item_edit(hid=hid) edit_dataset_attributes = self.components.edit_dataset_attributes annotation_component = edit_dataset_attributes.annotation_input annotation_component.wait_for_and_clear_and_send_keys(TEST_ANNOTATION) info_component = edit_dataset_attributes.info_input info_component.wait_for_and_clear_and_send_keys(TEST_INFO) edit_dataset_attributes.save_button.wait_for_and_click() edit_dataset_attributes.alert.wait_for_visible() # assert success message, name updated in form and in history panel assert edit_dataset_attributes.alert.has_class("alert-success") # reopen and check that attributes are updated self.home() ```
1 parent 2a4806b commit 3609832

1 file changed

Lines changed: 5 additions & 9 deletions

File tree

lib/galaxy/selenium/navigates_galaxy.py

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2249,21 +2249,17 @@ def history_multi_view_display_collection_contents(self, collection_hid, collect
22492249
def history_panel_item_edit(self, hid):
22502250
self.display_dataset(hid)
22512251

2252-
# Find and click the Edit tab - using a more reliable selector
2253-
# BVue generates '.nav-item a' elements with a title attribute matching the tab title
2254-
edit_tab_button = self.wait_for_selector_clickable(
2255-
".nav-item[title='Edit dataset attributes and metadata'] > a.nav-link"
2256-
)
2257-
edit_tab_button.click()
2252+
@retry_during_transitions
2253+
def _click_edit_tab():
2254+
self.components.dataset_view.edit_tab.wait_for_and_click()
22582255

2259-
# Wait for the edit attributes panel to be visible
2256+
_click_edit_tab()
22602257
self.components.edit_dataset_attributes._.wait_for_visible()
22612258

22622259
def display_dataset(self, hid):
22632260
item = self.history_panel_item_component(hid=hid)
22642261
item.display_button.wait_for_and_click()
2265-
# Wait for the DatasetView component to load
2266-
self.wait_for_selector_visible(".dataset-view")
2262+
self.components.dataset_view._.wait_for_visible()
22672263

22682264
def show_dataset_details(self, hid):
22692265
self.display_dataset(hid)

0 commit comments

Comments
 (0)