remove unneeded ReportInvocationErrorResponse, just respond with 204

Author: ahmedhamidawan

client/src/api/schema/schema.ts

@@ -17945,14 +17945,6 @@ export interface components {
              */
             message?: string | null;
         };
-        /** ReportInvocationErrorResponse */
-        ReportInvocationErrorResponse: {
-            /**
-             * Invocation error report response
-             * @description The messages returned for the state of the invocation error report.
-             */
-            messages: string[][];
-        };
         /** ReportJobErrorPayload */
         ReportJobErrorPayload: {
             /**
@@ -30768,13 +30760,11 @@ export interface operations {
         };
         responses: {
             /** @description Successful Response */
-            200: {
+            204: {
                 headers: {
                     [name: string]: unknown;
                 };
-                content: {
-                    "application/json": components["schemas"]["ReportInvocationErrorResponse"];
-                };
+                content?: never;
             };
             /** @description Request Error */
             "4XX": {

client/src/components/WorkflowInvocationState/WorkflowInvocationFeedback.vue

@@ -54,7 +54,7 @@ const stepsWithErrors = computed(() => {
 });
 
 async function submit(message: string): Promise<string[][] | undefined> {
-    const { data, error } = await GalaxyApi().POST("/api/invocations/{invocation_id}/error", {
+    const { error } = await GalaxyApi().POST("/api/invocations/{invocation_id}/error", {
         params: {
             path: { invocation_id: props.invocation.id },
         },
@@ -70,7 +70,7 @@ async function submit(message: string): Promise<string[][] | undefined> {
         return [[errorMessageAsString(error), "danger"]];
     }
 
-    return data.messages;
+    return [["Your email has been sent successfully. Thank you for your report.", "success"]];
 }
 </script>
 

lib/galaxy/schema/invocation.py

@@ -508,15 +508,6 @@ class InvocationReport(Model, WithModelClass):
     )
 
 
-class ReportInvocationErrorResponse(Model):
-    # messages: List[Union[Tuple[str, str], List[str]]]
-    messages: List[List[str]] = Field(
-        default=...,
-        title="Invocation error report response",
-        description="The messages returned for the state of the invocation error report.",
-    )
-
-
 class ReportInvocationErrorPayload(Model):
     invocation_id: DecodedDatabaseIdField = Field(
         default=...,

lib/galaxy/webapps/galaxy/api/workflows.py

@@ -64,7 +64,6 @@
     InvocationStepJobsResponseStepModel,
     InvocationUpdatePayload,
     ReportInvocationErrorPayload,
-    ReportInvocationErrorResponse,
     WorkflowInvocationRequestModel,
     WorkflowInvocationResponse,
 )
@@ -1453,19 +1452,20 @@ def write_store(
     @router.post(
         "/api/invocations/{invocation_id}/error",
         summary="Submits a bug report for a workflow run via the API.",
+        status_code=status.HTTP_204_NO_CONTENT,
     )
     def report_error(
         self,
         payload: ReportInvocationErrorPayload,
         invocation_id: InvocationIDPathParam,
         trans: ProvidesUserContext = DependsOnTrans,
-    ) -> ReportInvocationErrorResponse:
-        rval = self.invocations_service.report_error(
+    ):
+        self.invocations_service.report_error(
             trans,
             invocation_id,
             payload,
         )
-        return rval
+        return Response(status_code=status.HTTP_204_NO_CONTENT)
 
     @router.get("/api/invocations/{invocation_id}", summary="Get detailed description of a workflow invocation.")
     def show_invocation(

lib/galaxy/webapps/galaxy/services/invocations.py

@@ -44,7 +44,6 @@
     InvocationSerializationView,
     InvocationStep,
     ReportInvocationErrorPayload,
-    ReportInvocationErrorResponse,
     WorkflowInvocationRequestModel,
     WorkflowInvocationResponse,
 )
@@ -256,22 +255,21 @@ def write_store(
 
     def report_error(
         self, trans: ProvidesUserContext, invocation_id: DecodedDatabaseIdField, payload: ReportInvocationErrorPayload
-    ) -> ReportInvocationErrorResponse:
+    ):
         workflow_invocation = self._workflows_manager.get_invocation(
             trans, invocation_id, eager=True, check_ownership=False, check_accessible=True
         )
         email = payload.email
         if not email and not trans.anonymous:
             email = trans.user.email
-        messages = trans.app.error_reports.default_error_plugin.submit_invocation_report(
+        trans.app.error_reports.default_error_plugin.submit_invocation_report(
             invocation=workflow_invocation,
             user_submission=True,
             user=trans.user,
             email=email,
             message=payload.message,
             trans=trans,
         )
-        return ReportInvocationErrorResponse(messages=messages)
 
     def serialize_workflow_invocation(
         self,