close modals before accessibility check in workflow editor tests

Four tests were failing because they left a GModal open when the
@selenium_test decorator ran assert_baseline_accessibility(). When a
native <dialog> is open via showModal(), the browser marks everything
outside it as inert — axe-core skips those elements, making aria-roles
inapplicable and failing assert_passes('aria-roles').

- test_save_as, test_editor_invalid_tool_state, test_missing_tools:
  close the modal after taking the screenshot
- test_editor_subworkflow_tool_upgrade_message: the invalid tool state
  causes a save confirmation dialog to appear when saving — dismiss it

Author: ahmedhamidawan

lib/galaxy_test/selenium/test_workflow_editor.py

@@ -636,6 +636,7 @@ def test_save_as(self):
         self.screenshot("workflow_editor_edit_menu")
 
         self.components.workflow_editor.save_as_activity.wait_for_and_click()
+        self.components.workflow_editor.modal_button_close.wait_for_and_click()
 
     @selenium_test
     def test_editor_tool_upgrade(self):
@@ -723,6 +724,7 @@ def test_editor_subworkflow_tool_upgrade_message(self):
         self.screenshot("workflow_editor_subworkflow_tool_upgrade")
         self.components.workflow_editor.modal_button_close.wait_for_and_click()
         self.assert_workflow_has_changes_and_save()
+        self.components.workflow_editor.save_workflow_confirmation_button.wait_for_and_click()
 
     @staticmethod
     def set_text_element(element, value):
@@ -1049,6 +1051,7 @@ def test_editor_invalid_tool_state(self):
         self.assert_modal_has_text("Using version '0.2' instead of version '0.0.1'")
         self.assert_modal_has_text("Using default: '1'")
         self.screenshot("workflow_editor_invalid_state")
+        self.components.workflow_editor.modal_button_close.wait_for_and_click()
 
     @selenium_test
     def test_missing_tools(self):
@@ -1067,6 +1070,7 @@ def test_missing_tools(self):
         self.components.workflows.edit_button.wait_for_and_click()
         self.assert_modal_has_text("Tool is not installed")
         self.screenshot("workflow_editor_missing_tool")
+        self.components.workflow_editor.modal_button_close.wait_for_and_click()
 
     def tab_to(self, accessible_name, direction="forward"):
         for _ in range(100):