use consistent allowGeneratedTours prop; reuse ERROR_STATES

Co-authored-by: Aysam Guerler <aysam.guerler@gmail.com>

Author: ahmedhamidawan

client/src/components/Tool/Buttons/ToolTourGeneratorItem.vue

@@ -5,6 +5,7 @@ import { BDropdownItem } from "bootstrap-vue";
 import { storeToRefs } from "pinia";
 import { computed, ref, watch } from "vue";
 
+import { ERROR_STATES } from "@/api/jobs";
 import { generateTour, type TourDetails } from "@/api/tours";
 import { Toast } from "@/composables/toast";
 import { useHistoryItemsStore } from "@/stores/historyItemsStore";
@@ -14,8 +15,6 @@ import { errorMessageAsString } from "@/utils/simple-error";
 
 import LoadingSpan from "@/components/LoadingSpan.vue";
 
-const INVALID_UPLOAD_STATES = ["discarded", "failed", "error"];
-
 const props = defineProps<{
     toolId: string;
     toolVersion: string;
@@ -73,7 +72,7 @@ const allStatesOk = computed(() => {
 
 /** Checks if any of the states are invalid. */
 const anyStateInvalid = computed(() => {
-    return states.value.some((state) => state && INVALID_UPLOAD_STATES.includes(state));
+    return states.value.some((state) => state && ERROR_STATES.includes(state));
 });
 
 const waitedForItemsOk = computed<boolean>(() => localTourData.value !== null && allStatesOk.value);

client/src/components/Tool/ToolCard.vue

@@ -70,9 +70,8 @@ const props = defineProps({
         type: String,
         default: null,
     },
-    /** Whether there will be a `FormDisplay` rendered in the default slot with all tool inputs.
-     * For now, this is used to determine if tool generated tours can be offered. */
-    hasCompleteInputs: {
+    /** If tool generated tours can be offered. */
+    allowGeneratedTours: {
         type: Boolean,
         default: false,
     },
@@ -126,8 +125,8 @@ function onUpdatePreferredObjectStoreId(selectedToolPreferredObjectStoreId) {
 
 const showHelpForum = computed(() => isConfigLoaded.value && config.value.enable_help_forum_tool_panel_integration);
 
-const allowGeneratedTours = computed(() =>
-    Boolean(props.hasCompleteInputs && isConfigLoaded.value && config.value.enable_tool_generated_tours),
+const canGenerateTours = computed(() =>
+    Boolean(props.allowGeneratedTours && isConfigLoaded.value && config.value.enable_tool_generated_tours),
 );
 </script>
 
@@ -147,7 +146,7 @@ const allowGeneratedTours = computed(() =>
                     @onChangeVersion="onChangeVersion" />
                 <ToolOptionsButton
                     :id="props.id"
-                    :allow-generated-tours="allowGeneratedTours"
+                    :allow-generated-tours="canGenerateTours"
                     :tool-uuid="props.toolUuid"
                     :sharable-url="props.options.sharable_url"
                     :version="props.version"

client/src/components/Tool/ToolForm.vue

@@ -36,7 +36,7 @@
             :disabled="disabled || showExecuting"
             :allow-object-store-selection="config.object_store_allows_id_selection"
             :preferred-object-store-id="preferredObjectStoreId"
-            has-complete-inputs
+            allow-generated-tours
             itemscope="itemscope"
             itemtype="https://schema.org/CreativeWork"
             @updatePreferredObjectStoreId="onUpdatePreferredObjectStoreId"