Skip to content

Commit 9ea001b

Browse files
remove invocation email reporting TODO comments which are resolved
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
1 parent 8350f0e commit 9ea001b

2 files changed

Lines changed: 0 additions & 10 deletions

File tree

client/src/components/WorkflowInvocationState/WorkflowInvocationState.vue

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,6 @@ const invocationStateSuccess = computed(() => {
141141
);
142142
});
143143
144-
// TODO: Decide if the entire tab should only be rendered if it is the user's own workflow run.
145-
// We could check ownership by comparing the invocation history user ID in the `WorkflowInvocationFeedback` component?
146144
const canSubmitFeedback = computed(
147145
() =>
148146
invocationAndJobTerminal.value && (invocationState.value === "failed" || Boolean(stateCounts.value?.errorCount))

lib/galaxy/workflow/errors.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -122,14 +122,6 @@ def create_report(self, user, email="", message="", redact_user_details_in_bugre
122122
f"/published/workflow?id={stored_workflow_id_encoded}&version={workflow_version}", qualified=True
123123
)
124124

125-
# TODO: We could maybe also include the invocation messages, but I believe they often link steps
126-
# which aren't neccessarily the ones where the first jobs fail.
127-
# invocation_messages = self.invocation.messages
128-
# # Format messages for display
129-
# if invocation_messages:
130-
# messages_str = "\n".join([f"- {msg[0].reason}" for msg in invocation_messages])
131-
# else:
132-
# messages_str = "No messages"
133125

134126
# Build the email message
135127
if redact_user_details_in_bugreport:

0 commit comments

Comments
 (0)