👌 verdi presto: only treat AIIDA_NO_DAEMON_AUTOSTART=1 as truthy

The previous implementation treated any non-empty value of
`AIIDA_NO_DAEMON_AUTOSTART` as "skip daemon". That made
`AIIDA_NO_DAEMON_AUTOSTART=0` and `=false` silently skip the
daemon, contrary to what those values read as.

The env var is an internal escape hatch for the Docker init
script (and similar CI setups), not a public API surface. Keep
the recognized form narrow: only the literal string `1` skips
the daemon. Any other value (`0`, `true`, `false`, empty, typos)
falls through to "start the daemon", which is the safe default.

Drop the env var from user-facing reference: `--help` and
`command_line.rst` no longer mention it. Documenting it in the
CLI reference would turn an internal hatch into public API and
require a deprecation cycle to remove. The Docker init script
already comments why it sets the var; that's the right place
for consumer-side docs. A short comment near the call site
in `cmd_presto.py` keeps it discoverable for future maintainers
via `grep`.

Tests: parametrize over representative non-`1` values (`0`,
`true`, `false`, empty, `banana`) to lock in that none of them
skip the daemon.

Author: GeigerJ2

docs/source/reference/command_line.rst

@@ -319,8 +319,7 @@ Below is a list with all available subcommands.
       * Create a default user for the profile (email can be configured through the `--email` option)
       * Set up the localhost as a `Computer` and configure it
       * Set a number of configuration options with sensible defaults
-      * Start the daemon (unless `--no-broker` is specified or the
-        `AIIDA_NO_DAEMON_AUTOSTART` environment variable is set)
+      * Start the daemon (unless `--no-broker` is specified)
 
       By default the command creates a profile that uses SQLite for the database. For the
       message broker, it automatically checks for RabbitMQ running on localhost. If found, it

src/aiida/cmdline/commands/cmd_presto.py

@@ -184,8 +184,7 @@ def verdi_presto(
     * Create a default user for the profile (email can be configured through the `--email` option)
     * Set up the localhost as a `Computer` and configure it
     * Set a number of configuration options with sensible defaults
-    * Start the daemon (unless `--no-broker` is specified or the
-      `AIIDA_NO_DAEMON_AUTOSTART` environment variable is set)
+    * Start the daemon (unless `--no-broker` is specified)
 
     By default the command creates a profile that uses SQLite for the database. For the message broker, it automatically
     checks for RabbitMQ running on localhost. If found, it configures RabbitMQ as the broker. Otherwise, it falls back
@@ -293,7 +292,9 @@ def verdi_presto(
 
     echo.echo_success('Configured the localhost as a computer.')
 
-    if broker_backend is not None and not os.environ.get('AIIDA_NO_DAEMON_AUTOSTART'):
+    # `AIIDA_NO_DAEMON_AUTOSTART` is an internal escape hatch for the Docker init script (see
+    # `.docker/aiida-core-base/s6-assets/init/aiida-prepare.sh`); deliberately undocumented in `--help`.
+    if broker_backend is not None and os.environ.get('AIIDA_NO_DAEMON_AUTOSTART') != '1':
         from aiida.common.exceptions import ConfigurationError
         from aiida.engine.daemon.client import DaemonException, get_daemon_client
 

tests/cmdline/commands/test_presto.py

@@ -118,14 +118,29 @@ def test_presto_starts_daemon(run_cli_command, mock_daemon_client):
 
 @pytest.mark.usefixtures('empty_config')
 def test_presto_no_daemon_autostart_env(run_cli_command, mock_daemon_client, monkeypatch):
-    """Test that setting ``AIIDA_NO_DAEMON_AUTOSTART`` skips the daemon auto-start."""
+    """Test that ``AIIDA_NO_DAEMON_AUTOSTART=1`` skips the daemon auto-start."""
     monkeypatch.setenv('AIIDA_NO_DAEMON_AUTOSTART', '1')
     result = run_cli_command(verdi_presto, ['--non-interactive'])
     assert 'Created new profile' in result.output
     assert 'Starting the daemon' not in result.output
     mock_daemon_client.start_daemon.assert_not_called()
 
 
+@pytest.mark.parametrize('value', ('0', 'true', 'false', '', 'banana'))
+@pytest.mark.usefixtures('empty_config')
+def test_presto_daemon_autostart_env_non_one(run_cli_command, mock_daemon_client, monkeypatch, value):
+    """Test that anything other than the literal string ``1`` does not skip the daemon.
+
+    Only ``AIIDA_NO_DAEMON_AUTOSTART=1`` is recognized; any other value (including ``0``, ``true``,
+    typos, or empty string) falls through to "start the daemon" so a misspelled or unrecognized
+    value doesn't silently disable the daemon.
+    """
+    monkeypatch.setenv('AIIDA_NO_DAEMON_AUTOSTART', value)
+    result = run_cli_command(verdi_presto, ['--non-interactive'])
+    assert 'Starting the daemon' in result.output
+    mock_daemon_client.start_daemon.assert_called_once_with()
+
+
 @pytest.mark.usefixtures('empty_config')
 def test_presto_no_broker_skips_daemon(run_cli_command, mock_daemon_client):
     """Test that ``verdi presto --no-broker`` skips the daemon auto-start (no broker means no daemon)."""