Update RemoteStashData and subclasses

Notes:
- all submodels share the same fields. Consider lifting up to base class. Ping @khsrali

Author: edan-bainglass

src/aiida/orm/nodes/data/remote/stash/base.py

@@ -37,7 +37,9 @@ class RemoteStashData(Data):
     _storable = False
 
     class Model(Data.Model):
-        stash_mode: StashMode = MetadataField(description='The mode with which the data was stashed')
+        stash_mode: StashMode = MetadataField(
+            description='The mode with which the data was stashed',
+        )
 
     def __init__(self, stash_mode: StashMode, **kwargs):
         """Construct a new instance

src/aiida/orm/nodes/data/remote/stash/compress.py

@@ -26,7 +26,7 @@ class RemoteStashCompressedData(RemoteStashData):
 
     class Model(RemoteStashData.Model):
         target_basepath: str = MetadataField(
-            description='The the target basepath',
+            description='The target basepath',
         )
         source_list: List[str] = MetadataField(
             description='The list of source files that were stashed',
@@ -39,7 +39,7 @@ def __init__(
         self,
         stash_mode: StashMode,
         target_basepath: str,
-        source_list: List,
+        source_list: List[str],
         dereference: bool,
         **kwargs,
     ):

src/aiida/orm/nodes/data/remote/stash/custom.py

@@ -25,28 +25,32 @@ class RemoteStashCustomData(RemoteStashData):
     _storable = True
 
     class Model(RemoteStashData.Model):
-        target_basepath: str = MetadataField(description='The the target basepath')
-        source_list: List[str] = MetadataField(description='The list of source files that were stashed')
+        target_basepath: str = MetadataField(
+            description='The target basepath',
+        )
+        source_list: List[str] = MetadataField(
+            description='The list of source files that were stashed',
+        )
 
     def __init__(
         self,
         stash_mode: StashMode,
         target_basepath: str,
-        source_list: List,
+        source_list: List[str],
         **kwargs,
     ):
         """Construct a new instance
 
         :param stash_mode: the stashing mode with which the data was stashed on the remote.
         """
+        if stash_mode != StashMode.SUBMIT_CUSTOM_CODE:
+            raise ValueError('`RemoteStashCustomData` can only be used with `stash_mode == StashMode.COPY`.')
+
         super().__init__(stash_mode, **kwargs)
 
         self.target_basepath = target_basepath
         self.source_list = source_list
 
-        if stash_mode != StashMode.SUBMIT_CUSTOM_CODE:
-            raise ValueError('`RemoteStashCustomData` can only be used with `stash_mode == StashMode.COPY`.')
-
     @property
     def target_basepath(self) -> str:
         """Return the target basepath.

src/aiida/orm/nodes/data/remote/stash/folder.py

@@ -28,23 +28,34 @@ class RemoteStashFolderData(RemoteStashData):
     _storable = True
 
     class Model(RemoteStashData.Model):
-        target_basepath: str = MetadataField(description='The the target basepath')
-        source_list: List[str] = MetadataField(description='The list of source files that were stashed')
-
-    def __init__(self, stash_mode: StashMode, target_basepath: str, source_list: List, **kwargs):
+        target_basepath: str = MetadataField(
+            description='The target basepath',
+        )
+        source_list: List[str] = MetadataField(
+            description='The list of source files that were stashed',
+        )
+
+    def __init__(
+        self,
+        stash_mode: StashMode,
+        target_basepath: str,
+        source_list: List,
+        **kwargs,
+    ):
         """Construct a new instance
 
         :param stash_mode: the stashing mode with which the data was stashed on the remote.
         :param target_basepath: the target basepath.
         :param source_list: the list of source files.
         """
+        if stash_mode != StashMode.COPY:
+            raise ValueError('`RemoteStashFolderData` can only be used with `stash_mode == StashMode.COPY`.')
+
         super().__init__(stash_mode, **kwargs)
+
         self.target_basepath = target_basepath
         self.source_list = source_list
 
-        if stash_mode != StashMode.COPY:
-            raise ValueError('`RemoteStashFolderData` can only be used with `stash_mode == StashMode.COPY`.')
-
     @property
     def target_basepath(self) -> str:
         """Return the target basepath.